Overview
Request 1169665 accepted
- Created by TheBlackCat
- In state accepted
Request History
TheBlackCat created request
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto accepted review
Check script succeeded
anag+factory added openSUSE:Factory:Staging:adi:28 as a reviewer
Being evaluated by staging project "openSUSE:Factory:Staging:adi:28"
anag+factory accepted review
Picked "openSUSE:Factory:Staging:adi:28"
licensedigger accepted review
The legal review is accepted preliminary. The package may require actions later on.
dimstar accepted review
anag+factory accepted review
Staging Project openSUSE:Factory:Staging:adi:28 got accepted.
anag+factory approved review
Staging Project openSUSE:Factory:Staging:adi:28 got accepted.
anag+factory accepted request
Staging Project openSUSE:Factory:Staging:adi:28 got accepted.
could you explain why we need those orig files?
They are needed for the tests. I don't know why.
if they are needed for the tests why do they have to be in the final package?
We tried removing them in the past and it caused problems, that is why they are in now.
This is a common issue with jupyterlab packages, they have these .orig files and they can't just be excluded. See, for example: https://build.opensuse.org/package/show/openSUSE:Factory/python-jupyterlab
We tried a lot of things with these packages and decided ultimately to leave those files in because excluding them caused more problems than they solved.
@TheBlackCat, @darix I am much more worried about skipping the
%buildphase. One of the most sacred rules of any FLOSS Linux distro is that everything must be built from sources. This package is now broken, and it should be removed from Factory asap, in my opinion. The same goes for sr#1169683.