Overview

Request 1169712 accepted

No description set
Loading...

Atri Bhattacharya's avatar

I added a blank %check section to who-knows-how-many of my packages just because of this rpmlint warning, which explicitly asked me to add it even if empty. Now I have to go deleting them again. I suggest you accept this sr and wait until the next update when I drop the empty check section again.


Marcus Rueckert's avatar

did you read the link in the previous message. the intent of the original rpmlint warning was never to add empty %check sections.


Atri Bhattacharya's avatar

Oh sure, I read the link. It does not matter to me what the intent was. The message from rpmlint previously was "Add the %check section even if empty". So I did. I would not have second guessed at the time when I packaged this that the intent of rpmlint was supposedly the opposite of what it was explicitly and clearly stating!

In any case, I promise to revert it, but it does not hurt to do it during the next update. I don't understand why you need to decline this sr given this situation.

Request History
Atri Bhattacharya's avatar

badshah400 created request


Ana Guerrero's avatar

anag+factory added as a reviewer

Being evaluated by staging project "openSUSE:Factory:Staging:adi:41"


Ana Guerrero's avatar

anag+factory accepted review

Picked "openSUSE:Factory:Staging:adi:41"


Factory Auto's avatar

factory-auto added opensuse-review-team as a reviewer

Please review sources


Factory Auto's avatar

factory-auto accepted review

Check script succeeded


Saul Goodman's avatar

licensedigger accepted review

The legal review is accepted preliminary. The package may require actions later on.


Marcus Rueckert's avatar

darix declined request

please remove the empty %check section,,https://github.com/rpm-software-management/rpmlint/pull/1222


Atri Bhattacharya's avatar

badshah400 reopened request


Marcus Rueckert's avatar

darix accepted review

Accepted review for by_group opensuse-review-team request 1169712 from user badshah400


Ana Guerrero's avatar

anag+factory accepted review

Staging Project openSUSE:Factory:Staging:adi:41 got accepted.


Ana Guerrero's avatar

anag+factory approved review

Staging Project openSUSE:Factory:Staging:adi:41 got accepted.


Ana Guerrero's avatar

anag+factory accepted request

Staging Project openSUSE:Factory:Staging:adi:41 got accepted.

openSUSE Build Service is sponsored by