Overview

Request 1169905 superseded

added tests



Markéta Machová's avatar

hi, I can see many pkgs failing with new rpmlint, but I can't see how this pkg fixes it


Markéta Machová's avatar

could you please explain it @dstoecker ?


Dirk Stoecker's avatar
author source maintainer target maintainer

This comment refers to the rejection of the first submission: "Please, take a look at rpmlint output and make sure it is as clean as possible."


Markéta Machová's avatar

sounds like @mcepl would like to review it :)


Matej Cepl's avatar

rpmlint is now fixed, but I have still one problem with this:

  1. Could we have the test suite running. Apparently, it is pytest based (at least by looking at https://git.launchpad.net/launchpadlib/tree/src/launchpadlib and https://git.launchpad.net/launchpadlib/tree/tox.ini.
Request History
Dirk Stoecker's avatar

dstoecker created request

added tests


Matej Cepl's avatar

mcepl declined request

* This is not a spec file for package python-requests-threads, is it?
* Please, don't use %python_build/%python_install, but %pyproject_wheel/%pyproject_install instead.
* Why python-six? Does the package truly need it? Please, try to create a patch (and send it upstream) to eliminate the need of that pacakge.
* Make sure rpmlint is as quiet as possible.


openSUSE Build Service is sponsored by