Overview
Request 1170003 superseded
The previous SR got superseded because I realised I could build and install it with just %{gleam_install}
- Created by Pi-Cla
- In state superseded
- Supersedes 1168701
- Superseded by 1170637
@Mailaender, @WernerFink, @anicka, @cyberiad, @davidnichols, @glaubitz, @jbrielmaier, @mge1512, @seife, @sleep_walker, @subik: review reminder
Request History
Pi-Cla created request
The previous SR got superseded because I realised I could build and install it with just %{gleam_install}
darix declined request
why is this going directly to cargo_install without cargo_build first?
are we using prebuilt binaries?
Pi-Cla reopened request
cargo_install calls the Rust command `cargo install` which both builds the designated crate and installs it.
cargo_build is actually redundant as cargo_install rebuilds again.
This is why I have removed cargo_build from the other Rust packages I maintain, running cargo_build would just waste vm time doing something that then gets redone again. If you want you may ask @uncomfyhalomacro or @firstyear to vouch for me @darix
For some further context the official installation instructions also do not call cargo build. https://gleam.run/getting-started/installing/#build-from-source The "build from source" instructions just say to git clone the repo and then run the make install cmd which does this:
cd compiler-cli && cargo install --path . --force --lockedwe can actually skip %build to %install tbh.
cargo installis just an alias to cargo build then install. much like howcargo testbuilds it first then tests. just some Rust things.TBH i get why Pi-Cla decided to use
cargo install. there is a bug when doing these in OBS of which idk why, that %check and %install will always be rebuild despite the existing cached build data at./targetdirectory@Mailaender, @WernerFink, @anicka, @cyberiad, @davidnichols, @glaubitz, @jbrielmaier, @mge1512, @seife, @sleep_walker, @subik: review reminder
@darix given the comments and the third staging bot mass ping are you willing to accept the request now? If you want we can discuss this on Matrix or Discord
cargo install should not rebuild. if it does it sounds like a bug that we should fix.
cargo build and then cargo install should be preferred imho.