Overview
Request 1170554 revoked
gretl 2024a
- Created by AndreasStieger
- In state revoked
Loading...
Request History
AndreasStieger created request
gretl 2024a
AndreasStieger revoked request
The source project 'home:AndreasStieger:branches:science' has been removed
Please change this to https:// instead of http://
Consider splitting out a lang package.
/usr/share/gretl/COPYING may be removed given the COPYING file is installed using %license anyway.
Otherwise looks good to me. Thanks for the sr.
Can you explain if these are real concerns or just "nits"? None of these negatively impact the package or the submission and may be fixed by anyone later.
One person's 'nit' is another's 'real concern'. I guess you can wait for someone else to review this sr then. Ignore mine.
That was my question. I would like to understand if it is a real concern. None of these are substantial to the package or the change.
Would you mind clarifying what exactly you mean by mentioning that I can "then" wait for someone else to review this?
In my opinion, the use of http:// in 2024, the extra disk space occupied by unnecessary locale files are actual issues. Ok, the duplicated license file, not so much, but still doesn't hurt to clean up. You think these are all mere nits, so I suggested we wait for a third person's opinion.
Unless I am mistaken, the back-end bot still runs with
--no-check-certificate. Also I did not touch this line at all.The previous package did not split the translations, I am not making any changes to the translations.
None of these hurt to clean up. But is it required in the context of this change?