Overview

Request 1171895 revoked

- use meson so translations get build and can be packaged
- simplify the spec file

Loading...

Michael Vetter's avatar

I'm not python packaging expert, but this seems wrong to me. Whats your rationale behind this?


Richard Rahl's avatar

what seems wrong?


Michael Vetter's avatar

Why the python change?


Richard Rahl's avatar

Well from how the software was packaged, we can depict that only the default python version should be used to build lutris. Which means the buildsystem autochooses python 3.11 right now. For sle it autoselects the backported python version (which is also 3.11 right now).

As a sideeffect when a new python version gets tested as default it will autoselect that and error out if the newer version has issues.

So i don't see a disasvantage to this in comparison to the hardcoded python version



Ferdinand Thiessen's avatar

I think it is OK if it still then works on leap.

But why left the commented line? If not needed remove that line:

#%{python_sitelib}/%{name}-*.egg-info


Richard Rahl's avatar

sorry, I forgot to add why I revoked it myself. I thought I understood what %?sle15_python_module_pythons does. but as it turned out, jubalh had this doubts. will fix it first and then return with a SR

Request History
Richard Rahl's avatar

rrahl0 created request

- use meson so translations get build and can be packaged
- simplify the spec file


Richard Rahl's avatar

rrahl0 revoked request

openSUSE Build Service is sponsored by