Put my credits on this code, I already wrote the code to support translations, you only copied and added support to Leap 15.6 and removed my previous contribution. Please revoke this and add the correspondent credits.
dude, i never saw that forumpost, and how can i steal your code, when I my first SR was a week earlier than when you branched. and no I don't check obs to steal "contributions". last comment from me.
Without explicitly testing it, I don't think it will work for Leap.
The python3 in Leap is too old.
Hence the _py variables. They must be used consistently and universally.
this is what I thought the sle15_python_module_pythons module made sure, that python3 will redirect to python311. but it doesn't. that's why whith this SR i reverted Leap to the _py variable. I did it this way (and TW on python3, so that we can at some point remove the leap stuff easier.
I don't understand the %prep %{_pyb} replacement to 3. That looks wrong.
Could you please enable 15.5 and 15.6 in your repo to see Leap?
Also "simplify the spec file" is a bit strange as change log ;-)
I'd also think that %{_py} should be used everywhere instead of 3, thought I see your rationale, but it's simply confusing. Using a string replace when dropping that is so easy, that it's not worth having the confusion now.
Put my credits on this code, I already wrote the code to support translations, you only copied and added support to Leap 15.6 and removed my previous contribution. Please revoke this and add the correspondent credits.
?? i didn't copy anything
and I just want to add to that, that my first SR is older than when you branched. so how should I be able to "steal" code from you?
https://build.opensuse.org/request/show/1173371
seems like you "stole" code from me https://build.opensuse.org/request/show/1171895
Nope. Watch this forum link: https://forums.opensuse.org/t/lutris-has-missing-translations/174723/13
First I tested, then forked: https://build.opensuse.org/package/show/home:JMarcosHP01/lutris
Watch the code, date, and hour from the branch and my own repo.
You can simply revoke. And add the previous changes, mention, etc. Then put your own code to support Leap 15.6 and .spec simplification.
dude, i never saw that forumpost, and how can i steal your code, when I my first SR was a week earlier than when you branched. and no I don't check obs to steal "contributions". last comment from me.
I never saw your last revoked contribution, so I had no idea you were also working on translations. This is my first contribution.
If I want to steal your code, I simply branch/fork you.
My code is apart from yours.
Anyway, let the maintainers decide what code to merge. So no problem here, dude.
Richards request was older than yours. This here is the superseded request.
@ecsos you did https://build.opensuse.org/package/rdiff/games:tools/lutris?linkrev=base&rev=91 What do you think about this change (apart from the meson/lang part).
Without explicitly testing it, I don't think it will work for Leap. The python3 in Leap is too old. Hence the _py variables. They must be used consistently and universally.
this is what I thought the sle15_python_module_pythons module made sure, that python3 will redirect to python311. but it doesn't. that's why whith this SR i reverted Leap to the _py variable. I did it this way (and TW on python3, so that we can at some point remove the leap stuff easier.
I don't understand the %prep %{_pyb} replacement to 3. That looks wrong.
Could you please enable 15.5 and 15.6 in your repo to see Leap?
Also "simplify the spec file" is a bit strange as change log ;-)
I'd also think that %{_py} should be used everywhere instead of 3, thought I see your rationale, but it's simply confusing. Using a string replace when dropping that is so easy, that it's not worth having the confusion now.
Also this spec file requires 'gettext-tools' for build, as the source file suggests:
https://github.com/lutris/lutris/blob/master/lutris.spec
Hi Dirk, You are right. %prep replacement is wrong. Leap needs here also python311 and not only python3 And everywhere it must %{_py} or %{_pyb}