Overview

Request 1176475 accepted

- Update to 2.63
- Cherry pick upstream
- fix for missing _GNU_SOURCE when building snap-seccomp
- unit tests fix
- ensure Go binaries have GNU build IDs

Loading...

Zygmunt Krynicki's avatar
reviewer target maintainer

One of the patches has:

  • mcmd := testutil.MockCommand(c, "snap", "echo 'snap is not mocked'; exit 1")
  • s.AddCleanup(mcmd.Restore)

Not mocked? Should that not say "snap is mocked"? Or did you mean to use this as a sanity check to ensure that we never shell out to "snap"?


Maciej Borzecki's avatar

It's a sanity check, the unit test was calling real /usr/bin/snap.

Request History
Maciej Borzecki's avatar

maciek_borzecki created request

- Update to 2.63
- Cherry pick upstream
- fix for missing _GNU_SOURCE when building snap-seccomp
- unit tests fix
- ensure Go binaries have GNU build IDs


Zygmunt Krynicki's avatar

zyga accepted review

Looks good, thanks!


Zygmunt Krynicki's avatar

zyga approved review

Looks good, thanks!


Zygmunt Krynicki's avatar

zyga accepted request

openSUSE Build Service is sponsored by