Request 1176730 (accepted)

This request supersedes: request 1176505 (Show diff)

Overview

Request 1176730 accepted

- fix bashism in %post profiles

- Update to AppArmor 4.0.1
Too many changes to list them here. See
https://gitlab.com/apparmor/apparmor/-/wikis/Release_Notes_4.0.1
for the detailed upstream release notes
- add tools-fix-redefinition.diff: fix redefinition of _ in tools
- add test-aa-notify.diff: relax test-aa-notify to avoid a mismatch
with argparse on Leap 15.5
- drop upstreamed patches:
- apparmor-abstractions-openssl-allow-version-specific-en.patch
- dovecot-unix_chkpwd.diff
- smbd-unix_chkpwd.diff
- apparmor-lessopen-profile.patch: update lessopen profile to
abi/4.0
- mark local/* as %ghost so that these dummy files don't get
installed anymore (changed existing local/files will be kept,
unchanged files will be deleted)
- switch to gitlab tarballs (without pregenerated libapparmor
configure script and prebuilt techdoc.pdf)
- run libapparmor autogen.sh (needs additional BuildRequires
autoconf, autoconf-archive, automake and libtool)
- no longer package techdoc.pdf - old documentation, not worth
the texlive BuildRequires we would need to build it
- drop old (up to 2.12) cache location /var/lib/apparmor/ and the
/etc/apparmor.d/cache symlink pointing to it
- drop apparmor-samba-include-permissions-for-shares.diff - no
longer needed, update-apparmor-samba-profile in Tumbleweed works
without a pre-existing local/usr.sbin.smbd-shares file
- drop ruby-2_0-mkmf-destdir.patch - this ancient patch doesn't
change a single bit in the resulting build (anymore?)
- drop apparmor-lessopen-nfs-workaround.diff - no longer needed
since Kernel 6.0 (see https://bugs.launchpad.net/bugs/1784499)
- drop ancient, unused update-trans.sh

Note: %post profiles contains a for loop calling "rm" (to delete unchanged /etc/apparmor.d/local/* files). Please double-check for possible side effects I didn't consider.

Created by cboltz 6 months ago
In state accepted
Supersedes 1176505

Submit apparmor

Comments for request 1176730 1
Comments for request 1176505 4

Marcus Rueckert (darix) - 6 months ago

reviewer

I will accept this right after but i will add some comments for if there is ever a follow up submission

you could make your life a bit easier with something like

%global old_local_files <list here>

and then using that instead of hardcoding the same list twice

https://bugzilla.suse.com/show_bug.cgi?id=1223578

your %ghost entries should probably look something like

%ghost %config %attr(0644,root,root) /path

Marcus Rueckert (darix) - 6 months ago

reviewer

did you test that %post scriptlet?

Christian Boltz (cboltz) - 6 months ago

author source maintainer

Yes, it worked as expected.

Marcus Rueckert (darix) - 6 months ago

reviewer

did you test it on systems which are not using bash as /bin/sh?

the == might be a bashism

Christian Boltz (cboltz) - 6 months ago

author source maintainer

Good catch, that's indeed a bashism. I'll submit a new SR with a single =

Request History

cboltz created request 6 months ago

- fix bashism in %post profiles

Note: %post profiles contains a for loop calling "rm" (to delete unchanged /etc/apparmor.d/local/* files). Please double-check for possible side effects I didn't consider.