Overview

Request 1180248 accepted

No description set
Loading...

Marcus Rueckert's avatar

why does the service needs root permissions to begin with? why not have the correct target users right in the service file?


Manfred Schwarb's avatar
author source maintainer

1) this package, resp. its invocation mechanism, is modelled after the package mlocate, as it is intended to be able to replace the unsupported package mlocate, and therefore wants to support all features of mlocate. 2) mlocate origins in sysV era where one had to switch user with su. It has the feature that the sysadmin could choose in /etc/sysconfig/locate whether he/she wants to run the locate service as user root or user nobody (default), so either all files or only publicly visible files are harvested. 3) to my knowledge, systemd does not support a dynamical selection of the invoked user, so User=${RUN_UPDATEDB_AS} does not work.

So there are two possibilities, either invoke the service with User=nobody and do not support the user selection capability provided by mlocate, or use "su".

Side note: Originally, plocate is invoked as root with SETGID bit set to collect all data. On query time, output is filtered according to the invoking user. As SETUID/SETGID flags are not very appreciated in general, I decided to remove the set-group bit and do things the same way as mlocate does.

Request History
Manfred Schwarb's avatar

manfred999 created request


Factory Auto's avatar

factory-auto added opensuse-review-team as a reviewer

Please review sources


Factory Auto's avatar

factory-auto accepted review

Check script succeeded


Saul Goodman's avatar

licensedigger accepted review

ok


Staging Bot's avatar

staging-bot added openSUSE:Factory:Staging:adi:6 as a reviewer

Being evaluated by staging project "openSUSE:Factory:Staging:adi:6"


Staging Bot's avatar

staging-bot accepted review

Picked "openSUSE:Factory:Staging:adi:6"


Marcus Rueckert's avatar

darix accepted review

Accepted review for by_group opensuse-review-team request 1180248 from user staging-bot


Ana Guerrero's avatar

anag+factory accepted review

Staging Project openSUSE:Factory:Staging:adi:6 got accepted.


Ana Guerrero's avatar

anag+factory approved review

Staging Project openSUSE:Factory:Staging:adi:6 got accepted.


Ana Guerrero's avatar

anag+factory accepted request

Staging Project openSUSE:Factory:Staging:adi:6 got accepted.

openSUSE Build Service is sponsored by