Overview
Request 1182493 accepted
* Update to version 4.4.0.
* Change License tag to NASA-1.3 in keeping with upstream.
* Switch to cmake+ninja for build.
* Switch BuildRequires to pkgconfig based packages where possible.
* Add a bunch of cmake build related patches to make the output close to that generated by autotools: cfitsio-devel-scripts-destination.patch. cfitsio-allow-user-specified-incdir.patch. cfitsio-cmake-lowercase-util-names.patch. cfitsio-cmake-match-autotools-soversion.patch.
- Created by badshah400
- In state accepted
- Supersedes 1180382
Is it really a good idea to switch from lower case names to uppercase. It's breaking and I personally hate these strange exe names. Probably comes from the windows world which is case-insensitive.
My suggestion would be to rename this to lower case.
Yeah, upstream's idea, not mine.
We could symlink the lower case names to the respective upper case binaries, but not having the upper-case bins at all might cause problems in the future when apps do catch up to the upstream naming scheme.
What do you think?
Well, I personally would use lower case and if this gets trouble fix it in the future ;-) I don't like useless symlinks..
OK, think I will patch the cmake file to rename them. I looked in their documentation and they do continue to use lower-case names for these utilities there too, so what you suggest makes every bit of sense.
Will work on it tonight. Thanks for the advice.
What bothers me more is the SOVERSION downgrade.
Filed and issue upstream: https://github.com/HEASARC/cfitsio/issues/21
Yup, that is a problem too. Thanks for the bug report.
Just had a look at the upstream situation and I think it will be the best if I switch this back to the autotools based build.
@Dmitry_R, @StefanBruens, @TheBlackCat, @adrianSuSE, @anag, @badshah400, @dstoecker, @eeich, @kwk, @lrupp, @mslacken, @openfoam, @psmt, @supergeeko: review reminder
Request History
badshah400 created request
* Update to version 4.4.0.
* Change License tag to NASA-1.3 in keeping with upstream.
* Switch to cmake+ninja for build.
* Switch BuildRequires to pkgconfig based packages where possible.
* Add a bunch of cmake build related patches to make the output close to that generated by autotools: cfitsio-devel-scripts-destination.patch. cfitsio-allow-user-specified-incdir.patch. cfitsio-cmake-lowercase-util-names.patch. cfitsio-cmake-match-autotools-soversion.patch.
badshah400 accepted request
@Dmitry_R, @StefanBruens, @TheBlackCat, @adrianSuSE, @anag, @badshah400, @dstoecker, @eeich, @kwk, @lrupp, @mslacken, @openfoam, @psmt: review reminder