Concerning the target project, I completely agree that this belongs to somewhere else than d:l:p. Just because something happens to be written in Python, doesn’t mean it is part of the Python ecosystem. The main knowledge required to maintain this script is, I guess, not the Python knowledge, but to know enough about whatever is “Bluetooth Low Energy” thingy.
As per Python comments. The thing with %if %{with test} is a common construct (together with _multibuild file) to split building and testing of a package into two independent steps and to avoid potential circular dependencies if for example testing requires more substantial dependencies than just a building and running of the package itself. I don’t know if it is relevant here.
The bcond conditionals are unintelligible and should not be used unless there is some very good reason which I do not see here. The conditional is defined based on other macro so it can as well be defined as plain macro.
If it will be your package, then obviously you should decide how it should be done. We are using this construct routinely in hundreds of other python-* packages, but whatever you say.
This looks more like it belongs into devel:languages:python, any reason you're submitting it to hardware instead?
Also, this separate test flavor looks unusual. Why not just conditionalize the %check in a single package?
Why not just provide a full GitHub URL for Source0, to verify the tarball? Your service-generated tarball name looks unusual.
Please discuss this with mcepl. For reference of his opinion see request #1184106.
Please do not use bcond. Either always run tests or use the flavor to decide.
Also the 'disabled' service type is deprecated, iirc 'manual' should be used instead.
Concerning the target project, I completely agree that this belongs to somewhere else than
d:l:p. Just because something happens to be written in Python, doesn’t mean it is part of the Python ecosystem. The main knowledge required to maintain this script is, I guess, not the Python knowledge, but to know enough about whatever is “Bluetooth Low Energy” thingy.As per Python comments. The thing with
%if %{with test}is a common construct (together with_multibuildfile) to split building and testing of a package into two independent steps and to avoid potential circular dependencies if for example testing requires more substantial dependencies than just a building and running of the package itself. I don’t know if it is relevant here.And yes,
Source:should come from URL, I agree.The bcond conditionals are unintelligible and should not be used unless there is some very good reason which I do not see here. The conditional is defined based on other macro so it can as well be defined as plain macro.
If it will be your package, then obviously you should decide how it should be done. We are using this construct routinely in hundreds of other
python-*packages, but whatever you say.@a_faerber, @duwe, @hreinecke, @jengelh, @lrupp, @michals, @seife, @seilerphilipp, @trenn, @tsaupe: review reminder