Overview

Request 1186171 accepted

No description set
Loading...

Marcus Rueckert's avatar
-   -DGDCM_USE_SYSTEM_POPPLER:BOOL=ON
+   -DGDCM_USE_SYSTEM_POPPLER:BOOL=ON \
+%if 0%{?suse_version} > 1500
+   -DCMAKE_CXX_STANDARD=20
+%endif

for safety i would do the following:

-   -DGDCM_USE_SYSTEM_POPPLER:BOOL=ON
+   -DGDCM_USE_SYSTEM_POPPLER:BOOL=ON \
+%if 0%{?suse_version} > 1500
+   -DCMAKE_CXX_STANDARD=20 \
+%endif
%nil

if someone cleans up the newline after the %endif and builds on leap. the first like of %make_build will be pulled into the cmake cmdline


Michael Vetter's avatar
author source maintainer

@krop


Christophe Marin's avatar

Well, don't. problem solved


Christophe Marin's avatar

If "someone" clears the new line, "someone" will get a build error and figure on its own.


Atri Bhattacharya's avatar

Just FYI, this is currently blocking updates to insighttoolkit (and probably others).

Request History
Michael Vetter's avatar

jubalh created request


Factory Auto's avatar

factory-auto added opensuse-review-team as a reviewer

Please review sources


Factory Auto's avatar

factory-auto accepted review

Check script succeeded


Saul Goodman's avatar

licensedigger accepted review

ok


Staging Bot's avatar

staging-bot added as a reviewer

Being evaluated by staging project "openSUSE:Factory:Staging:adi:70"


Staging Bot's avatar

staging-bot accepted review

Picked "openSUSE:Factory:Staging:adi:70"


Marcus Rueckert's avatar

darix accepted review

Accepted review for by_group opensuse-review-team request 1186171 from user staging-bot


Ana Guerrero's avatar

anag+factory accepted review

Staging Project openSUSE:Factory:Staging:adi:70 got accepted.


Ana Guerrero's avatar

anag+factory approved review

Staging Project openSUSE:Factory:Staging:adi:70 got accepted.


Ana Guerrero's avatar

anag+factory accepted request

Staging Project openSUSE:Factory:Staging:adi:70 got accepted.

openSUSE Build Service is sponsored by