Overview
Request 1187874 superseded
new package vault-sync: synchronize secrets between HashiCorp Vault (or OpenBao) instances
- Created by ojkastl_buildservice
- In state superseded
- Supersedes 1187242
- Superseded by 1187968
-
Open review for
opensuse-review-team
- Open review for openSUSE:Factory:Staging:adi:15
does the service really need to be able to write its config file?
Hmm, no, I do not think so.
You mean the %dir %attr(755,%{name}, %{name}) %{_sysconfdir}/%{name}/ in line 91?
yes. my recommendation would be
root:%{name} u=rwX,g=rX,o=
Request History
ojkastl_buildservice created request
new package vault-sync: synchronize secrets between HashiCorp Vault (or OpenBao) instances
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto accepted review
Check script succeeded
anag+factory added openSUSE:Factory:Staging:adi:15 as a reviewer
Being evaluated by staging project "openSUSE:Factory:Staging:adi:15"
anag+factory accepted review
Picked "openSUSE:Factory:Staging:adi:15"
licensedigger accepted review
The legal review is accepted preliminary. The package may require actions later on.
darix declined request
you only partially fixed the user/group thing,,also you can simplify your life by replacing this,,```,install -d -m 0755 %{buildroot}%{_sysconfdir}/%{name}/,echo "# empty on purpose, please check /usr/share/doc/packages/vault-sync/vault-sync.example.yaml" > %{buildroot}%{_sysconfdir}/%{name}/vault-sync.yaml,```,,with,,```,install -d -m 0750 %{buildroot}%{_sysconfdir}/%{name}/,echo "# empty on purpose, please check /usr/share/doc/packages/vault-sync/vault-sync.example.yaml" > %{buildroot}%{_sysconfdir}/%{name}/vault-sync.yaml,chmod o= %{buildroot}%{_sysconfdir}/%{name}/vault-sync.yaml,```,,then you can do:,,```,%config(noreplace) %attr(-,root, %{name}) %{_sysconfdir}/%{name}/,```,,that way you have the permissions correct in %install and only need attr for user/group
ojkastl_buildservice superseded request
superseded by 1187968
