Overview
Request 1188330 accepted
No description set
- Created by dirkmueller
- In state accepted
Loading...
Request History
dirkmueller created request
anag+factory added as a reviewer
Being evaluated by staging project "openSUSE:Factory:Staging:adi:60"
anag+factory accepted review
Picked "openSUSE:Factory:Staging:adi:60"
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto accepted review
Check script succeeded
licensedigger accepted review
ok
darix accepted review
ok
dimstar_suse accepted review
Staging Project openSUSE:Factory:Staging:adi:60 got accepted.
dimstar_suse approved review
Staging Project openSUSE:Factory:Staging:adi:60 got accepted.
dimstar_suse accepted request
Staging Project openSUSE:Factory:Staging:adi:60 got accepted.
your changes entry talks about pinning the python-requests ... but that isnt reflected in the spec file. Also is this really something we want?
Hello Marcus, thanks for the Input and sorry for the late response! This is just something I copied from the upstream changelog: https://github.com/httpie/cli/releases/tag/3.2.3 I don't exactly know why the httpie developers decided to do this, it seems to be related to this commit: https://github.com/httpie/cli/commit/7f03c52d2237440c5a672296ce6955aae4ed4f09 Apparently new versions of python-requests seem to cause some Issues with https and the developers think that pinning python-requests to that specific version would fix these issues: https://github.com/httpie/cli/issues/1581 https://github.com/httpie/cli/issues/1583
However, I must admit I haven't fully looked into all possible consequences of this change and forgot to reflect that change in the spec file. Do you think it would be better to make a patch that reverts 7f03c52d2237440c5a672296ce6955aae4ed4f09 for the openSUSE version of httpie or do you think pinning python-requests is fine and I should just also reflect the pinning in the spec file instead?
that patch is not reall enforcing anything. but we have a newer python-requests version in the distro already. so if we accept it you might see similar bugs to the upstream bugs.
the question is who needs to fix what (requests or httpie upstream) to make it work with newer versions.
You seem to be correct, I can still reproduce issue #1583 with my current build of httpie 3.2.3, the problem is that all these bugs already affect the current httpie 3.2.2 as well.
httpie upstream seams to be unwilling to fix anything regarding that on their end. I'm kind of clueless how to go about this, other distros like Arch seem to just ignore the issue, even though it seems quite impacful (it essentialy completely breaks all https functionality of httpie and only regular http works).
Of course I could just try to bundle python-requests 2.31.0 with httpie, but I don't know if that's optimal. We could alternatively just postpone updating httpie until either the python-requests developers or httpie developers provide a proper solution for the problem.
tbh ... i would say we can also accept this update ... i mean it doesnt break anything more what is already broken