Overview
Request 1188463 revoked
- Created by tiwai
- In state revoked
-
Open review for
factory-staging
Request History
tiwai created request
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto accepted review
Check script succeeded
licensedigger accepted review
ok
darix accepted review
Accepted review for by_group opensuse-review-team request 1188463 from user factory-auto
anag+factory set openSUSE:Factory:Staging:H as a staging project
Being evaluated by staging project "openSUSE:Factory:Staging:H"
anag+factory accepted review
Picked "openSUSE:Factory:Staging:H"
anag+factory added factory-staging as a reviewer
Being evaluated by group "factory-staging"
anag+factory accepted review
Unstaged from project "openSUSE:Factory:Staging:H"
anag+factory set openSUSE:Factory:Staging:D as a staging project
Being evaluated by staging project "openSUSE:Factory:Staging:D"
anag+factory accepted review
Picked "openSUSE:Factory:Staging:D"
anag+factory added factory-staging as a reviewer
Being evaluated by group "factory-staging"
anag+factory accepted review
Unstaged from project "openSUSE:Factory:Staging:D"
anag+factory declined request
Needs to add separate flavor nuspell:doc, see comment
tiwai revoked request
The fix from Atri was merged / submitted.
Hi @tiwai:
You're adding a new BuildRequires on pandoc, this means we'll need to add pandoc to the ring1 set of packages and this is something we want to avoid at all costs. Can you please add the nuspell documentation in a different flavour such as nuspell:doc that we can keep outside of ring1? Thank you.
@badshah400
You're adding a new BuildRequires on pandoc, this means we'll need to add pandoc to the ring1 set of packages and this is something we want to avoid at all costs. Can you please add the nuspell documentation in a different flavour such as nuspell:doc that we can keep outside of ring1? Thank you.
Hi, sure. Actually pandoc is used to generate the man file, which does not make sense as part of a separate doc package. We will just disable it and drop the BuildReq on pandoc instead.
Thank you