Request 1189265: Submit google-authenticator-libpam

Overview

Request 1189265 accepted

No description set

Created by dimstar about 2 months ago
In state accepted

Submit google-authenticator-libpam

Comments for request 1189265 2

Marcus Rueckert (darix) - about 2 months ago

reviewer

you could do adapt our requires_file macro to give you a recommends:

%define requires_file() %( readlink -f '%*' | LC_ALL=C xargs -r rpm -q --qf 'Requires: %%{name} >= %%{epoch}:%%{version}\\n' -f | sed -e 's/ (none):/ /' -e 's/ 0:/ /' | grep -v "is not")

we dont need the version in Recommends:

%define recommends_file() %( readlink -f '%*' | LC_ALL=C xargs -r rpm -q --qf 'Recommends: %%{name}\\n' -f | sed -e 's/ (none):/ /' -e 's/ 0:/ /' | grep -v "is not")

usage:

%recommends_file %{_libdir}/libqrencode.so

Dominique Leuenberger (dimstar) - about 2 months ago

author reviewer source maintainer

Could - but:

Would require an additional BuildRequires
Would potentially recommend a .so.N that is not even handled by the code

./src/google-authenticator.c:  void *qrencode = dlopen("libqrencode.so.2", RTLD_NOW | RTLD_LOCAL);
./src/google-authenticator.c:  if (!qrencode) {
./src/google-authenticator.c:    qrencode = dlopen("libqrencode.so.3", RTLD_NOW | RTLD_LOCAL);
./src/google-authenticator.c:  if (!qrencode) {
./src/google-authenticator.c:    qrencode = dlopen("libqrencode.so.4", RTLD_NOW | RTLD_LOCAL);

so the current recommends is in fact exactly what the code supports and is thus the most correct form