Overview

Request 1189433 accepted

* Update to version 2.6.3.
* Run spec-cleaner to cleanup some obsolete tags.
* tin-2.0.0_toggle_rot_key.patch: Refresh to apply with -p1.
* Drop tin-2.0.0-no_datetime_in_bin.patch: __DATE__ and __TIME__ are now correctly set to source tarball date by SOURCE_DATE_EPOCH.
* Use %autosetup -p1 to setup build dir.
* Disable FORGERY, docs/INSTALL suggests that it "should not be used in a free accessible tin".
* Drop potentially confusing sysconfdir macro.

Loading...

Atri Bhattacharya's avatar

PING?


Atri Bhattacharya's avatar

This has been pending for more than a month, unfortunately. If the project maintainers need a bit more help to review incoming reqs, I am willing to help. Please consider adding me as a prj maintainer. Thanks in advance.


Dr. Werner Fink's avatar
reviewer target maintainer

OK ... as David seems not available anymore ... can I ask why you skip the define of NO_DATE_TIME_IN_BIN? If this would avoid adding build date this should not happ as any build date should not be part of the final binary .... this because this makes it difficult to compare the resulting binaries of different builds


Atri Bhattacharya's avatar

The build date is still not part of any of the binaries. SOURCE_DATE_EPOCH sets any __DATE__ and __TIME__ variables to the makefile/configure script of the source tarball, therefore referring to the upstream release date of the source which does not change between rebuilds.

Thanks for getting back to me about the sr.


Request History
Atri Bhattacharya's avatar

badshah400 created request

* Update to version 2.6.3.
* Run spec-cleaner to cleanup some obsolete tags.
* tin-2.0.0_toggle_rot_key.patch: Refresh to apply with -p1.
* Drop tin-2.0.0-no_datetime_in_bin.patch: __DATE__ and __TIME__ are now correctly set to source tarball date by SOURCE_DATE_EPOCH.
* Use %autosetup -p1 to setup build dir.
* Disable FORGERY, docs/INSTALL suggests that it "should not be used in a free accessible tin".
* Drop potentially confusing sysconfdir macro.


Dr. Werner Fink's avatar

WernerFink accepted review

I'm fine with ... what is about David Haller? Is David active?


Dr. Werner Fink's avatar

WernerFink accepted request

Thanks

openSUSE Build Service is sponsored by