Overview

Request 1189943 accepted

I'm the upstream maintainer and would like to maintain it in Factory, using devel:languages:go as its devel project.


Jeff Kowalczyk's avatar
reviewer target maintainer

Hello Paolo, thank you for the submission. Accepting. I will suggest a few edits via SR before we forward the package to Factory. I think any user can initiate the new package submit from devel:languages:go to Factory, but if you don't mind please hold off on that step while we complete those small edits, set package metadata, etc.

First would be to set the .spec file name and package field Name: to the name of the binary, qubesome. The first stanza with global defines building up a structured Name: golang-github-com-foo is obsolete following the transition to Go modules. We can accept this SR since you already have the correct target package path qubesome.

Example packages that cover common cases include:

https://build.opensuse.org/projects/devel:languages:go/packages/vale/files/vale.spec

https://build.opensuse.org/projects/devel:languages:go/packages/hugo/files/hugo.spec

https://build.opensuse.org/projects/devel:languages:go/packages/delve/files/delve.spec


Jeff Kowalczyk's avatar
reviewer target maintainer

@pjbgf: Submitted to Factory in https://build.opensuse.org/request/show/1190053 .

If you would like -trimpath and the -X version metadata restored to packaging, not a problem.


Paulo Gomes's avatar
author source maintainer

Hey Jeff,

Thank you so much for your timely review and the changes to the package and metadata. I learned a lot just going through them.

The reasoning you gave around dropping -trimpath was quite sound, so I am happy to keep it out. On the version metadata, I will revisit it once I have version 0.0.3 released.

Cheers, Paulo

Request History
Paulo Gomes's avatar

pjbgf created request

I'm the upstream maintainer and would like to maintain it in Factory, using devel:languages:go as its devel project.


Jeff Kowalczyk's avatar

jfkw accepted review

Review OK for devel:languages:go


Jeff Kowalczyk's avatar

jfkw approved review

Review OK for devel:languages:go


Jeff Kowalczyk's avatar

jfkw accepted request

Accept to devel:languages:go

openSUSE Build Service is sponsored by