Overview

Request 1191875 accepted

- Setup obsoletes/provides to cover the renaming of the library SONAME.

- update to first source tarball release v0.3.1. Drop git SCM service.

- change library package name from libcosmos-0_2_0 to libcosmos-0, because it
needs to follow the library's SONAME which is libcosmos.so.0.

- Update to version 0.2.1+gitcb2663e:
* buildsystem: fix bug in passing multiple parameters via CXXFLAGS & friends
* test/thread.cxx: fix potential race condition in isCallerThread()
* buildsystem: passthrough ASAN_OPTIONS
* tests: on unit test error cat logfile to stderr
* bump lib version which now contains memory mapping API
* github action: disable ODR iolation checks in unit tests in sanitizer build
* README.md: add info about recent developments
* check.py: support more fine tuning regarding which configs are built
* tests: mman: disable core dumping for expected SEGFAULT
* check.py: use dedicated buildroot that is cleaned before each config
* LinkLayerAddress: make some exotic protocols optional
* support older toolchains and non-x86 architectures better
* buildsystem.py: be prepared for TERM not existing
* buildsystem.py: satisfy flake8 "missing whitespace after comma"
* check.py: refer to current HEAD, not to master
* .github: add github action workflow file
* global: fix spelling errors in comments and documentation
* mman.hxx: fix doxygen list item indentation
* README: remove mention of memory mappings, which are available by now
* addrinfo test: switch UDP resolve from http to tftp
* feature: add support for memory mapping functionality
* FileBase: add runcate() member function

Loading...

Matthias Gerstner's avatar

Can you please be a bit more specific what exactly is wrong?


Marcus Rueckert's avatar

shared libraries get removed at the distribution level via weak remover. you do not have to add provides/obsoletes for them.


Matthias Gerstner's avatar

The point here is that a library package rename happened. My previous sr#1189341 was declined, because I was not handling the package rename.

This package rename business is pretty confusing to me. What should it be now?


Jan Engelhardt's avatar
reviewer source maintainer

naming error, should be libcosmos0 not libcosmo-0. (bug in rpmlint, looking at it)


Matthias Gerstner's avatar

Where exactly are you seeing this naming error?


Jan Engelhardt's avatar
reviewer source maintainer

well, in the .spec obviously: 62-%files -n libcosmos-0_2_0 63+%files -n libcosmos-0 cf. libz1 (not libz-1), libzvbi0 (not libzvbi-0), etc. After all, the DT_SONAME is libcosmos.so.0 not libcosmos-0.so.


Matthias Gerstner's avatar

I see! You just mean the fact that rpmlint doesn't complain about the SONAME mismatch.

You had a typo there in your first comment so I thought there is some reference towards some libcosmo-0.

Request History
Matthias Gerstner's avatar

mgerstner created request

- Setup obsoletes/provides to cover the renaming of the library SONAME.

- update to first source tarball release v0.3.1. Drop git SCM service.

- change library package name from libcosmos-0_2_0 to libcosmos-0, because it
needs to follow the library's SONAME which is libcosmos.so.0.

- Update to version 0.2.1+gitcb2663e:
* buildsystem: fix bug in passing multiple parameters via CXXFLAGS & friends
* test/thread.cxx: fix potential race condition in isCallerThread()
* buildsystem: passthrough ASAN_OPTIONS
* tests: on unit test error cat logfile to stderr
* bump lib version which now contains memory mapping API
* github action: disable ODR iolation checks in unit tests in sanitizer build
* README.md: add info about recent developments
* check.py: support more fine tuning regarding which configs are built
* tests: mman: disable core dumping for expected SEGFAULT
* check.py: use dedicated buildroot that is cleaned before each config
* LinkLayerAddress: make some exotic protocols optional
* support older toolchains and non-x86 architectures better
* buildsystem.py: be prepared for TERM not existing
* buildsystem.py: satisfy flake8 "missing whitespace after comma"
* check.py: refer to current HEAD, not to master
* .github: add github action workflow file
* global: fix spelling errors in comments and documentation
* mman.hxx: fix doxygen list item indentation
* README: remove mention of memory mappings, which are available by now
* addrinfo test: switch UDP resolve from http to tftp
* feature: add support for memory mapping functionality
* FileBase: add runcate() member function


Factory Auto's avatar

factory-auto added opensuse-review-team as a reviewer

Please review sources


Factory Auto's avatar

factory-auto accepted review

Check script succeeded


Staging Bot's avatar

staging-bot added openSUSE:Factory:Staging:adi:14 as a reviewer

Being evaluated by staging project "openSUSE:Factory:Staging:adi:14"


Staging Bot's avatar

staging-bot accepted review

Picked "openSUSE:Factory:Staging:adi:14"


Saul Goodman's avatar

licensedigger accepted review

ok


Marcus Rueckert's avatar

darix declined request

obsoleting shared libraries is not done at package level


Dominique Leuenberger's avatar

dimstar_suse reopened request

Package rename is due to previously wrong name (same content), in this case the obsoletes tag is correct; we do not obsolete when the lib content changes (e.g parallel installable)


Dominique Leuenberger's avatar

dimstar accepted review


Dominique Leuenberger's avatar

dimstar_suse accepted review

Staging Project openSUSE:Factory:Staging:adi:14 got accepted.


Dominique Leuenberger's avatar

dimstar_suse approved review

Staging Project openSUSE:Factory:Staging:adi:14 got accepted.


Dominique Leuenberger's avatar

dimstar_suse accepted request

Staging Project openSUSE:Factory:Staging:adi:14 got accepted.

openSUSE Build Service is sponsored by