Overview
Request 1194762 revoked
- Created by AndreasStieger
- In state revoked
-
Open review for
opensuse-review-team
-
Open review for
AndreasStieger
-
Open review for
factory-staging
Request History
AndreasStieger created request
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto accepted review
Check script succeeded
anag+factory set openSUSE:Factory:Staging:H as a staging project
Being evaluated by staging project "openSUSE:Factory:Staging:H"
anag+factory accepted review
Picked "openSUSE:Factory:Staging:H"
licensedigger accepted review
The legal review is accepted preliminary. The package may require actions later on.
anag+factory added factory-staging as a reviewer
Being evaluated by group "factory-staging"
anag+factory accepted review
Unstaged from project "openSUSE:Factory:Staging:H"
anag+factory set openSUSE:Factory:Staging:I as a staging project
Being evaluated by staging project "openSUSE:Factory:Staging:I"
anag+factory accepted review
Picked "openSUSE:Factory:Staging:I"
favogt_factory added AndreasStieger as a reviewer
Needs discussion
jengelh declined review
Should probably revert this: cryptsetup is for setup, not for crypto. What's in pbkdf2_generic.c is just piecing together HMAC bits, there's no (apparent) hard crypto, which is all handled by various backends (gcrypt, kernel, openssl, nss, what-have-you).
jengelh declined request
Should probably revert this: cryptsetup is for setup, not for crypto. What's in pbkdf2_generic.c is just piecing together HMAC bits, there's no (apparent) hard crypto, which is all handled by various backends (gcrypt, kernel, openssl, nss, what-have-you).
anag+factory reopened request
Reopened via staging workflow.
anag+factory added factory-staging as a reviewer
Being evaluated by group "factory-staging"
anag+factory accepted review
Unstaged from project "openSUSE:Factory:Staging:I"
anag+factory declined request
Declined via staging workflow.
AndreasStieger revoked request
I am curious ... all the crypto stuff that needs performance with cryptsetup ... isnt that in the kernel? why do we need those libraries also extra optimized?
Good question. @RN do you have any measurements or other rationale for this proposed change?
Based on my understanding the block crypto is in kernel while the KDF is in userspace
Optimizing the kdf would be helpful, but FWICT it already uses separate libraries for those (libargon2 resp. libopenssl) already.
I was simply asked to compile a package in such a way that it supposedly gives a performance boost. And these are the results of his
Before: https://paste.opensuse.org/pastes/16bf254bf877
After: https://paste.opensuse.org/pastes/f4588bb3447b
Yes, Jan pointed it out correctly. The cryptsetup tool is using various backends for the crytpo part. By default it uses openssl.
--with-crypto_backend=BACKEND crypto backend (gcrypt/openssl/nss/kernel/nettle) [openssl]
Therefore these hwcaps optimizations should not affect cryptsetup itself.
I moved the data and discussion to boo#1229473