Request 1196153 (revoked)

Overview

Request 1196153 revoked

No description set

Created by michael-chang 22 days ago
In state revoked

Submit grub2

Comments for request 1196153 5

Dominique Leuenberger (dimstar) - 19 days ago

reviewer

@snwint

This grub package layout change results in installation-images buildfailures:

https://build.opensuse.org/package/live_build_log/openSUSE:Factory:Staging:F/installation-images:openSUSE/standard/x86_64

[  217s] adding package grub2 [2.12-1.3.x86_64]
[  217s] cp: cannot stat '/usr/src/packages/BUILD/installation-images-17.137/tmp/cache//grub2/rpm//usr/share/grub2/unicode.pf2': No such file or directory
[  217s] mk_image: failed to move /usr/share/grub2/unicode.pf2 to grub2-efi at lib/AddFiles.pm line 646 in data/boot/theme.file_list line 47.
[  217s] make: *** [Makefile:205: boot-themes] Error 25
[  217s] error: Bad exit status from /var/tmp/rpm-tmp.R5U4QD (%build)

Alberto Planas Dominguez (aplanas) - 19 days ago

KIWI has a similar issue here: https://github.com/OSInside/kiwi/issues/2624

A workaround is to include the bootloader pattern in the image (not required for the new grub2bls subpackage)

Michael Chang (michael-chang) - 16 days ago

author source maintainer

The unicode.pf2 file has been moved to the grub2-common package, which should be installed automatically if the grub2 package is installed by following this dependency chain: grub2 -> grub2-i386-pc -> grub2-common. That way if the package resolver is functioning correctly, there should be no noticeable difference, except that grub2 now serves as a meta-package to pull in the default dependencies for a cpu architecture.

It seems that the section in theme.file_list needs to be updated to reflect this change. However, I'm uncertain how to modify it to indicate other required (new) dependencies. Does it support resolving package dependencies out of box?

grub2:
  m /usr/share/grub2/unicode.pf2 grub2-efi

Thanks.

Michael Chang (michael-chang) - 15 days ago

author source maintainer

My sincere apology. I just take more deeper look and found it is a problem in my change that I overlooked some dependency in non-x86 architecture.. I will fix and resubmit!

Michael Chang (michael-chang) - 15 days ago

author source maintainer

@snwint

I have fixed the issue in grub2 and submitted to factory: https://build.opensuse.org/request/show/1198414

But the error remains in installation-images. If I change data/boot/theme.file_list to include grub2-common it seemed to work. Really needs your help.

    if exists(grub2-common)
      grub2-common:
    m /usr/share/grub2/unicode.pf2 grub2-efi
    else
      grub2:
    m /usr/share/grub2/unicode.pf2 grub2-efi
    endif

Thanks.