Overview

Request 1196376 revoked

libabigail 2.5

Loading...

Jan Engelhardt's avatar

no, your FTBFS was because of something related to bash-completion packaging

+ rm abidb
abidb: No such file or directory

Jan Engelhardt's avatar

The strong opinion of curly braces vs. curly braces is as useless as the discussion of tabs vs. spaces - which was essentially solved by .editorconfig. There should simply not be a fuzz about it, there just happens to be a default in spec-cleaner. This should not be about which one is right

I'll make sure to add editorconfig files to OBS packages in the future.

Request History
Andreas Stieger's avatar

AndreasStieger created request

libabigail 2.5


Jan Engelhardt's avatar

jengelh declined request

The package 'devel:tools / libabigail' is now maintained at https://src.opensuse.org/jengelh/libabigail#master


Jan Engelhardt's avatar

jengelh declined request

Please do not switch %a to %{a}, it just adds a lot of diff noise.
I do not think we need the bconds, they're just always set to one specific value anyway.
bash-completions subpackages are seen as out of fashion by the collective; the completion file can just be in the main package and depending on bash-completion just isn't necessary.
FTBFS.


Andreas Stieger's avatar

AndreasStieger revoked request

The strong opinion of curly braces vs. curly braces is as useless as the discussion of tabs vs. spaces - which was essentially solved by `.editorconfig`. There should simply not be a fuzz about it, there just happens to be a default in spec-cleaner. This should not be about which one is right

The bcond statements help document more clearly the intent of which feature should be on, and which feature requires which dependency. This helps in case this is flipped off later for other targets, or to not collect build dependencies for features removed later. Also, does it hurt to have them?

And FTBFS... well that's just you moving the package to git.

openSUSE Build Service is sponsored by