Overview
Request 1197967 superseded
- fix build for Tumbleweed, by using ffmpeg-6 not ffmpeg-7 (forwarded request 1197966 from rrahl0)
- Created by rrahl0
- In state superseded
- Superseded by 1200898
-
Open review for
opensuse-review-team
-
Open review for
factory-staging
Request History
rrahl0 created request
- fix build for Tumbleweed, by using ffmpeg-6 not ffmpeg-7 (forwarded request 1197966 from rrahl0)
dimstar_suse added openSUSE:Factory:Staging:adi:18 as a reviewer
Being evaluated by staging project "openSUSE:Factory:Staging:adi:18"
dimstar_suse accepted review
Picked "openSUSE:Factory:Staging:adi:18"
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto accepted review
Check script succeeded
licensedigger accepted review
The legal review is accepted preliminary. The package may require actions later on.
dimstar declined review
+%if 0%{?suse_version} >= 1600
+BuildRequires: ffmpeg-6-mini-devel
+%else
BuildRequires: pkgconfig(libavcodec)
BuildRequires: pkgconfig(libavdevice)
BuildRequires: pkgconfig(libavfilter)
BuildRequires: pkgconfig(libavformat)
+%endif
It would be better to version lock the BuildRequires to ensure you get what works (if porting to ffmpeg7 is not possible)
e.g.
BuildRequires: pkgconfig(libav...) < 5x.0
dimstar declined request
+%if 0%{?suse_version} >= 1600
+BuildRequires: ffmpeg-6-mini-devel
+%else
BuildRequires: pkgconfig(libavcodec)
BuildRequires: pkgconfig(libavdevice)
BuildRequires: pkgconfig(libavfilter)
BuildRequires: pkgconfig(libavformat)
+%endif
It would be better to version lock the BuildRequires to ensure you get what works (if porting to ffmpeg7 is not possible)
e.g.
BuildRequires: pkgconfig(libav...) < 5x.0
anag+factory reopened request
Reopened via staging workflow.
anag+factory added factory-staging as a reviewer
Being evaluated by group "factory-staging"
anag+factory accepted review
Unstaged from project "openSUSE:Factory:Staging:adi:18"
anag+factory declined request
Declined via staging workflow.
superseded by 1200898
can you please check if you can patch this to use ffmpeg-7? there is a few packages already have patches which you can use as inspiration.
IMO the correct way is to
so I looked into this, and sadly it doesn't work that way, as for some reason ffmpeg-6-mini-devel doesn't expose the pkgconfig(). (while still there). so I can't pkgconfig() < 61