Overview

Request 1201876 accepted

- Update to version 1.06:
* [ARM] Added support for inferring the SoC from the uarch
* [ARM] Added support for inferring the SoC from PCI devices
* [ARM] Added support for SVE detection
* [X86] Significantly improved support for old x86 CPUs
* [X86] Added support for Hygon CPUs
* [ARM and X86] Added support for measuring max CPU frequency
* [ARM and X86] Added `--measure-max-freq` option to manually
trigger CPU max frequency measurement
* [All] Added support for NO_COLOR

Loading...

R N's avatar

Not sure what would be better to leave newer package broken or ignore this --debug results in %check section for ARM architectures.

sr#1201873#diff_1_n33


Michael Vetter's avatar

why do you add another whitespace at ExclusiveArch?


R N's avatar

That's from osc vc automation, not me.


Michael Vetter's avatar

osc vc doesnt manipulate the spec file. I'm talking about 25+ExclusiveArch: %{arm} aarch64 x86_64 ppc ppc64 ppc64le


R N's avatar

It is. +# Copyright (c) 2024 SUSE LLC and +License: GPL-2.0-only This lines also changed from automation, not by me.


Michael Vetter's avatar

This is not the line "I'm talking about". Please read the message above again.


R N's avatar

I just showed an example that it manipulate the .spec file indeed.


R N's avatar

Okay, my bad. It's because of osc ci , not because of osc vc.
After "Running source_service 'format_spec_file' ..."
But change still comes from automation, not from me.
https://paste.opensuse.org/pastes/355f6e3fc6ce


Michael Vetter's avatar

ah i see now that its actually on the correct line then. all good.


R N's avatar

Actually my question was - is it acceptable to ignore %check section --debug results to for rpm build process with some architectures... so is it?


Michael Vetter's avatar

depends on the maintainer and the test


R N's avatar

Here is %check section with line inside
"%{buildroot}%{_bindir}/%{name} --debug"
I mentioned it in sr#1201873#diff_1_n33, as you can see issue of cpufetch --debug results --
*** buffer overflow detected ***

So, I'm not sure is it acceptable or not to ignore this error for ARM devices


Michael Vetter's avatar

lets wait for @gnuykeat to review. if he doesnt have time for several days then i'll take a look. but he is official maintainer so i would like to wait for him first.


R N's avatar

Sure, thank you.


R N's avatar

@jubalh
Sorry, I just wanted to ask... should we fix build process for ARM architectures?
Because only issue for them it's buffer overflow detection on %check section.
(As I asked wanted in sr#1201873)


Michael Vetter's avatar

We should fix it if we know how to. But not by just removing the check section (I think). My hope is that ARM maintainers will see the build failure and send a SR to fix it correctly. Another option might be to report it upstream so they can fix their test for ARM.


R N's avatar

Okay, thank you.


Request History
R N's avatar

RN created request

- Update to version 1.06:
* [ARM] Added support for inferring the SoC from the uarch
* [ARM] Added support for inferring the SoC from PCI devices
* [ARM] Added support for SVE detection
* [X86] Significantly improved support for old x86 CPUs
* [X86] Added support for Hygon CPUs
* [ARM and X86] Added support for measuring max CPU frequency
* [ARM and X86] Added `--measure-max-freq` option to manually
trigger CPU max frequency measurement
* [All] Added support for NO_COLOR


Michael Vetter's avatar

jubalh accepted request

Accepting due to long time no response from maintainer

openSUSE Build Service is sponsored by