Overview
Please also note that the license cannot be GPL-2.0-only if advancemame is based on MAME which is partially BSD-licensed.
From the MAME homepage (https://www.mamedev.org/):
The MAME project as a whole is distributed under the terms of the GNU General Public License, 2 (GPL-2.0), since it contains code made available under multiple GPL-compatible licenses. A great majority of files (over 90% including core files) are under the BSD-3-Clause License and we would encourage new contributors to distribute files under this license.
Please note that MAME is a registered trademark of Gregory Ember, and permission is required to use the "MAME" name, logo or wordmark.
Removing the overwritten CFLAGS and CXXFLAGS (which is not allowed, you may only append individual flags) also reveals a lot of code problems:
[ 622s] I: Program causes undefined operation [ 622s] (likely same variable used twice and post/pre incremented in the same expression). [ 622s] e.g. x = x++; Split it in two operations. [ 622s] W: advancemame sequence-point mess/machine/pc_mouse.c:48, 186, 225, 227 [ 622s] W: advancemame sequence-point src/cpu/e132xs/e132xs.c:2004 [ 622s] W: advancemame sequence-point src/cpu/h6280/h6280ops.h:675, 737, 729, 667, 713, 651 [ 622s] W: advancemame sequence-point src/cpu/m6502/opsc02.h:187, 180 [ 622s] W: advancemame sequence-point src/cpu/spc700/spc700.c:221 [ 622s] W: advancemame sequence-point src/machine/pic8259.c:294, 302, 315 [ 622s] W: advancemame sequence-point src/vidhrdw/atari.c:1263, 1265, 1300, 1363, 1376 [ 622s] W: advancemame sequence-point srcmess/cpu/e132xs/e132xs.c:2004 [ 622s] W: advancemame sequence-point srcmess/cpu/h6280/h6280ops.h:675, 737, 729, 667, 713, 651 [ 622s] W: advancemame sequence-point srcmess/cpu/m6502/opsc02.h:187, 180 [ 622s] W: advancemame sequence-point srcmess/cpu/m6502/opsce02.h:244, 258, 251, 236 [ 622s] W: advancemame sequence-point srcmess/cpu/spc700/spc700.c:221 [ 622s] W: advancemame sequence-point srcmess/machine/pic8259.c:294, 302, 315 [ 622s] W: advancemame sequence-point srcmess/vidhrdw/atari.c:1263, 1265, 1300, 1363, 1376 [ 622s] [ 622s] I: Program is likely to break with new gcc. Try -fno-strict-aliasing. [ 622s] W: advancemame strict-aliasing-punning src/cpu/m68000/m68kfpu.c:355, 377, 485 [ 622s] W: advancemame strict-aliasing-punning src/cpu/mips/mips3.c:126, 125, 124, 133, 132, 131, 140, 139, 138, 135, 134, 123, 130, 137 [ 622s] W: advancemame strict-aliasing-punning src/cpu/tms32031/tms32031.c:628, 629, 630, 631, 632, 633, 634, 635 [ 622s] W: advancemame strict-aliasing-punning src/vidhrdw/segas32.c:743, 751 [ 622s] W: advancemame strict-aliasing-punning srcmess/cpu/m68000/m68kfpu.c:355, 377, 485 [ 622s] W: advancemame strict-aliasing-punning srcmess/cpu/mips/mips3.c:126, 125, 124, 133, 132, 131, 140, 139, 138, 135, 134, 123, 130, 137 [ 622s] [ 622s] I: Program is using uninitialized variables. [ 622s] Note the difference between "is used" and "may be used" [ 622s] W: advancemame uninitialized-variable ./src/memory.h:999 [ 622s] [ 622s] I: Statement might potentially overflow a destination buffer, where a size larger [ 622s] than the actual buffer was specified [ 622s] E: advancemame destbufferoverflow /usr/include/bits/string_fortified.h:90 [ 622s]
Request History
gallochri created request
AdvanceMAME/MESS are unofficial MAME/MESS versions with an
advanced video support for helping the use with TVs, Arcade
monitors, PC monitors and LCD screens.
@bigironman, @duwe, @glaubitz, @kwk, @msmeissn, @seife, @snwint: review reminder