Request 1208109 (declined)

Overview

Request 1208109 declined

No description set

Created by susnux 12 days ago
In state declined

Submit clanlib

Comments for request 1208109 1

Dominique Leuenberger (dimstar) - 11 days ago

reviewer

the .pc files have dependencies on stuff, which configure decided not to build:

[   19s] Checking for ClanLib Modules to build...
[   19s] ========================================
[   19s] checking whether we should try to build API documentation... yes
[   19s] checking whether we should try to build clanApp... auto
[   19s] checking whether we should try to build clanDisplay... auto
[   19s] checking whether we should try to build clanGL... auto
[   19s] checking whether we should try to build clanSound... auto
[   19s] checking whether we should try to build clanNetwork... auto
[   19s] checking whether we should try to build clanUI... auto
[   19s] checking whether we should try to build clanXML... auto
[   19s] 
[   19s] Checking for clanDisplay stuff
[   19s] ==============================
[   19s] checking for ttf... yes
[   20s] checking for linux/joystick.h... yes
[   20s] checking for linux/input.h... yes
[   20s] checking for Xinerama... no
[   20s] configure: WARNING:  *** Cannot find Xinerama. Try installing libxinerama-dev. Disabling clanDisplay
[   20s] configure: WARNING:  *** clanGL  depends on clanDisplay. Disabling clanGL
…
[   21s] The following modules will be built:
[   21s] 
[   21s]                    clanCore = yes (SSE2 Enabled)
[   21s]                     clanApp = yes
[   21s]                 clanDisplay = no
[   21s]                      clanGL = no
[   21s]                   clanSound = yes (ALSA Enabled)
[   21s]                 clanNetwork = yes
[   21s]                      clanUI = yes
[   21s]                     clanXML = yes

yet, we get: nothing provides pkgconfig(clanDisplay-4.2) = 4.2.0 needed by clanlib-devel-4.2.0.x86_64

https://github.com/sphair/ClanLib/blob/master/Setup/Unix/pkgconfig/clanUI.pc.in has a hard dependency on clanDisplay -

so clanUI should also be disabled if clanDisplay is not built (to be reported to upstream)

Request History

susnux created request 12 days ago

factory-auto added opensuse-review-team as a reviewer 12 days ago

Please review sources

factory-auto accepted review 12 days ago

Check script succeeded

staging-bot added as a reviewer 12 days ago

Being evaluated by staging project "openSUSE:Factory:Staging:adi:55"

staging-bot accepted review 12 days ago

Picked "openSUSE:Factory:Staging:adi:55"

darix accepted review 12 days ago

Accepted review for by_group opensuse-review-team request 1208109 from user staging-bot
the gcc handling could be done nicer: https://nordisch.org/posts/rpm-spec-files-conditionals-and-forcing/