Overview
Request 1208603 superseded
- Fix subpackage names and their dependencies.
- Add missing ldconfig scriptlets.
- Build libkeymap and create additional subpackages.
- Created by sbrabec
- In state superseded
- Supersedes 1208593
- Superseded by 1216987
- Open review for opensuse-review-team
- Open review for factory-staging
Request History
sbrabec created request
- Fix subpackage names and their dependencies.
- Add missing ldconfig scriptlets.
- Build libkeymap and create additional subpackages.
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto accepted review
Check script succeeded
licensedigger accepted review
ok
anag+factory set openSUSE:Factory:Staging:I as a staging project
Being evaluated by staging project "openSUSE:Factory:Staging:I"
anag+factory accepted review
Picked "openSUSE:Factory:Staging:I"
anag+factory added factory-staging as a reviewer
Being evaluated by group "factory-staging"
anag+factory accepted review
Unstaged from project "openSUSE:Factory:Staging:I"
anag+factory set openSUSE:Factory:Staging:H as a staging project
Being evaluated by staging project "openSUSE:Factory:Staging:H"
anag+factory accepted review
Picked "openSUSE:Factory:Staging:H"
dimstar_suse added factory-staging as a reviewer
Being evaluated by group "factory-staging"
dimstar_suse accepted review
Unstaged from project "openSUSE:Factory:Staging:H"
New fixed commit.
some questions
%ldconfig_scripts -n %{pkgname}
macro nowlibkbdfile1 is a private shared library. It does not have any includes, so it cannot be linked to a third party project. That is why I decided to not pack it separately.
(Well, I did not check that it is called from libkeymapfile1 or from the kbd itself. In the first case, the current layout makes sense. In the second case, it would be better to make it a part of kbd package itself.)
It's not private, there exists a /usr/include/kbdfile.h.
Ah, I overseen it.
waiting for feedback on review questiins - backlog
rq 1216987