Overview

Request 1208603 superseded

- Fix subpackage names and their dependencies.
- Add missing ldconfig scriptlets.
- Build libkeymap and create additional subpackages.

Loading...

Marcus Rueckert's avatar

some questions

  1. the changes entry doesnt mention why we need the extra libraries. it would be useful to know in the future if we need to focus on keeping it
  2. how sure are we that the shared libraries will get bumped in sync? if they are likely to be bumped separately they need to go into different subpackages
  3. there is a %ldconfig_scripts -n %{pkgname} macro now

Jan Engelhardt's avatar
  1. "because upstream produces them". Basically, packages should not get stunted at the distro level just because you don't like the bike shed's color. Someone may grow a dependency later and then would be very upset if kbd-devel didn't behave the same as the upstream variant.
  2. Examination of the git log suggest the author is a serious automake user, and that makes it all the more likely we will be seeing independent bumps; in other words, libkbdfile.so.1 should be separate from libkeymap1.rpm.

Stanislav Brabec's avatar
author source maintainer

libkbdfile1 is a private shared library. It does not have any includes, so it cannot be linked to a third party project. That is why I decided to not pack it separately.

(Well, I did not check that it is called from libkeymapfile1 or from the kbd itself. In the first case, the current layout makes sense. In the second case, it would be better to make it a part of kbd package itself.)


Jan Engelhardt's avatar

It's not private, there exists a /usr/include/kbdfile.h.


Stanislav Brabec's avatar
author source maintainer

Ah, I overseen it.


Dominique Leuenberger's avatar

waiting for feedback on review questiins - backlog


Request History
Stanislav Brabec's avatar

sbrabec created request

- Fix subpackage names and their dependencies.
- Add missing ldconfig scriptlets.
- Build libkeymap and create additional subpackages.


Factory Auto's avatar

factory-auto added opensuse-review-team as a reviewer

Please review sources


Factory Auto's avatar

factory-auto accepted review

Check script succeeded


Saul Goodman's avatar

licensedigger accepted review

ok


Ana Guerrero's avatar

anag+factory set openSUSE:Factory:Staging:I as a staging project

Being evaluated by staging project "openSUSE:Factory:Staging:I"


Ana Guerrero's avatar

anag+factory accepted review

Picked "openSUSE:Factory:Staging:I"


Ana Guerrero's avatar

anag+factory added factory-staging as a reviewer

Being evaluated by group "factory-staging"


Ana Guerrero's avatar

anag+factory accepted review

Unstaged from project "openSUSE:Factory:Staging:I"


Ana Guerrero's avatar

anag+factory set openSUSE:Factory:Staging:H as a staging project

Being evaluated by staging project "openSUSE:Factory:Staging:H"


Ana Guerrero's avatar

anag+factory accepted review

Picked "openSUSE:Factory:Staging:H"


Dominique Leuenberger's avatar

dimstar_suse added factory-staging as a reviewer

Being evaluated by group "factory-staging"


Dominique Leuenberger's avatar

dimstar_suse accepted review

Unstaged from project "openSUSE:Factory:Staging:H"


Stanislav Brabec's avatar

sbrabec superseded request

New fixed commit.

openSUSE Build Service is sponsored by