Overview
Request 122779 accepted
- updated to 0.08
- Remove a double layer of string eval that was introduced in 0.07 as an
intermediate step in figuring out the unique package thing - it's not
necessary with the final implementation, and just makes things slower
and hides errors.
- the given source is now evaled in a unique package for every
eval_closure call (it used to always be evaled in the Eval::Closure
package, which was especially buggy). this is to avoid issues where one
eval_closure modifies the global environment (by, say, importing a
function), which could mess up a later call. unfortunately, this means
that the memoization stuff no longer works, since it will result in
memoized results using the original package, which defeats the purpose.
i'm open to suggestions on how to safely reenable it though.
- clean up a few stray lexicals we were still closing over in the eval
Request History
coolo created request
- updated to 0.08
- Remove a double layer of string eval that was introduced in 0.07 as an
intermediate step in figuring out the unique package thing - it's not
necessary with the final implementation, and just makes things slower
and hides errors.
- the given source is now evaled in a unique package for every
eval_closure call (it used to always be evaled in the Eval::Closure
package, which was especially buggy). this is to avoid issues where one
eval_closure modifies the global environment (by, say, importing a
function), which could mess up a later call. unfortunately, this means
that the memoization stuff no longer works, since it will result in
memoized results using the original package, which defeats the purpose.
i'm open to suggestions on how to safely reenable it though.
- clean up a few stray lexicals we were still closing over in the eval
factory-auto added a reviewer
Please review sources
oertel approved review
reviewed by ro
coolo accepted request
checkin
licensedigger accepted review
{"approve": "preliminary, version number changed"}
factory-auto accepted review
Builds for repo pure_factory
oertel accepted review
reviewed by ro
