Overview

Request 132788 accepted

Starting to push GNOME:Next...

Loading...
Request History
Dominique Leuenberger's avatar

dimstar created request

Starting to push GNOME:Next...


Vincent Untz's avatar

vuntz approved review

+1 but:

a) not sure why Requires(post) goes after Provides/Obsoletes. Probably a bug in spec-cleaner; those changes should be reverted.

b) (baselibs.conf too) => (in baselibs.conf too)

c) this is wrong:
-Obsoletes: pango-devel-64bit
+Obsoletes: pkgconfig(pango)-64bit

d) typo in .changes: "Hangul Hebrew" => "Hangul, Hebrew"

e) harfbuzz BR should be >= 0.9


Vincent Untz's avatar

vuntz accepted request

checkin


Vincent Untz's avatar

vuntz accepted review

+1 but:

a) not sure why Requires(post) goes after Provides/Obsoletes. Probably a bug in spec-cleaner; those changes should be reverted.

b) (baselibs.conf too) => (in baselibs.conf too)

c) this is wrong:
-Obsoletes: pango-devel-64bit
+Obsoletes: pkgconfig(pango)-64bit

d) typo in .changes: "Hangul Hebrew" => "Hangul, Hebrew"

e) harfbuzz BR should be >= 0.9

openSUSE Build Service is sponsored by