Overview
Request 136473 superseded
required by gtkwave sr#136472
- Created by Dmitry_R
- In state superseded
- Superseded by 136546
-
Open review for
legal-team
Request History
Dmitry_R created request
required by gtkwave sr#136472
licensedigger added a reviewer
{"delegate": "new package r>3"}
factory-auto added a reviewer
Please review sources
a_jaeger declined request
I suggest you remove these lines completly:
+install -dD -m 0755 %{buildroot}%{_docdir}/%{name}
+install -m 0644 \
+ AUTHORS COPYING ChangeLog \
+ doc/ext/README_deliver \
+ doc/ext/*.htm* doc/int/*.htm* \
+ %{buildroot}%{_docdir}/%{name}
+cp -r examples %{buildroot}%{_docdir}/%{name}/
instead add to the %files section of the doc package:
%doc AUTHORS COPYING ChangeLog doc/ext/README_deliver doc/ext/*.htm* doc/int/*.htm*
%doc examples
rpm will do the above magic for you
The rest looks fine, so please make the changes, test them and resubmit.
Thanks a lot!
Andreas
Superseded by request 136546
licensedigger accepted review
{"delegate": "new package r>3"}
factory-auto accepted review
Builds for repo openSUSE_Factory
a_jaeger declined review
I suggest you remove these lines completly:
+install -dD -m 0755 %{buildroot}%{_docdir}/%{name}
+install -m 0644 \
+ AUTHORS COPYING ChangeLog \
+ doc/ext/README_deliver \
+ doc/ext/*.htm* doc/int/*.htm* \
+ %{buildroot}%{_docdir}/%{name}
+cp -r examples %{buildroot}%{_docdir}/%{name}/
instead add to the %files section of the doc package:
%doc AUTHORS COPYING ChangeLog doc/ext/README_deliver doc/ext/*.htm* doc/int/*.htm*
%doc examples
rpm will do the above magic for you
The rest looks fine, so please make the changes, test them and resubmit.
Thanks a lot!
Andreas
