Overview
Request 158332 superseded
Push GNOME:Next
- Created by dimstar
- In state superseded
- Superseded by 158746
- Open review for dimstar
Request History
dimstar created request
Push GNOME:Next
Zaitor accepted review
You get to decide yourself if the off by one identation is reason to reject ( there is also one from the 8 jan)
+Tue Feb 5 19:01:56 UTC 2013 - dimstar@opensuse.org
+
+- Update to version 2.35.6:
+ + proxy/gnome: Fixed several bugs:
+ - Multithreaded usage could result in crashes.
+ - In "automatic" mode, synchronous lookups would obey
+ ignore-hosts, but asynchronous lookups would not.
+ - lookup_async() would never notice if the proxy settings
+ switched from "automatic" to "manual" or "none" (and would
+ make a synchronous D-Bus call when switching in the other
+ direction).
+ - If given an invalid URI, lookup_async() would return a
+ successful result (and leak the GError that it was supposed
+ to have returned), and lookup() would return both the error
+ and the proxy (leaking one or the other, depending on how
+ the caller behaved).
+ + Updated translations.
Zaitor approved review
You get to decide yourself if the off by one identation is reason to reject ( there is also one from the 8 jan)
+Tue Feb 5 19:01:56 UTC 2013 - dimstar@opensuse.org
+
+- Update to version 2.35.6:
+ + proxy/gnome: Fixed several bugs:
+ - Multithreaded usage could result in crashes.
+ - In "automatic" mode, synchronous lookups would obey
+ ignore-hosts, but asynchronous lookups would not.
+ - lookup_async() would never notice if the proxy settings
+ switched from "automatic" to "manual" or "none" (and would
+ make a synchronous D-Bus call when switching in the other
+ direction).
+ - If given an invalid URI, lookup_async() would return a
+ successful result (and leak the GError that it was supposed
+ to have returned), and lookup() would return both the error
+ and the proxy (leaking one or the other, depending on how
+ the caller behaved).
+ + Updated translations.
Zaitor added a reviewer
See above
superseded by 158746