Overview
Request 206849 superseded
- caps-fix-double-free.diff:
Fix double free in destructor of caps plugin (bnc#842420)
Note About reviewer's previous comment:
"multimedia:libs/ladspa-devel should _link to multimedia:libs/ladspa"
In short: DON'T BE BOTHERED. It's irrelevant with the fix.
In Long:
_link of ladspa-devel isn't done intentionally due to the historical reason.
ladspa-devel needs *NEVER* to be rebuilt.
ladspa-devel was a separate repo in the past and indepdendent from ladspa
main package, because ladspa-devel is nothing but a single header file,
and triggering rebuilds of other packages due to each ladspa plugin change
makes no sense. But during the migration to OBS, ladspa-devel repo was merged
into ladspa, and it looks as if this is bound together.
So, linking is exactly what we do *NOT* want to do at all. Again,
ladspa-devel needs never to be rebuilt. It's just a single rock-solid
C header file.
At best, we should move ladspa-devel out of ladsla repo to an indivual repo
again. But this is utterly irrelevant from this particular fix, so
no reason to do it for now (especially as we need an update for 13.1).
We can clean up the package repo later.
Thanks.
- Created by tiwai
- In state superseded
- Supersedes 201448
- Superseded by 210502
- Open review for opensuse-review-team
Request History
tiwai created request
- caps-fix-double-free.diff:
Fix double free in destructor of caps plugin (bnc#842420)
Note About reviewer's previous comment:
"multimedia:libs/ladspa-devel should _link to multimedia:libs/ladspa"
In short: DON'T BE BOTHERED. It's irrelevant with the fix.
In Long:
_link of ladspa-devel isn't done intentionally due to the historical reason.
ladspa-devel needs *NEVER* to be rebuilt.
ladspa-devel was a separate repo in the past and indepdendent from ladspa
main package, because ladspa-devel is nothing but a single header file,
and triggering rebuilds of other packages due to each ladspa plugin change
makes no sense. But during the migration to OBS, ladspa-devel repo was merged
into ladspa, and it looks as if this is bound together.
So, linking is exactly what we do *NOT* want to do at all. Again,
ladspa-devel needs never to be rebuilt. It's just a single rock-solid
C header file.
At best, we should move ladspa-devel out of ladsla repo to an indivual repo
again. But this is utterly irrelevant from this particular fix, so
no reason to do it for now (especially as we need an update for 13.1).
We can clean up the package repo later.
Thanks.
factory-auto added a reviewer
Please review sources
factory-auto added a reviewer
Please review build success
factory-auto accepted review
Check script succeeded
licensedigger accepted review
{"approve": "license and version number unchanged: 1.13"}
factory-repo-checker declined request
multimedia:libs/ladspa-devel should _link to multimedia:libs/ladspa
factory-repo-checker declined review
multimedia:libs/ladspa-devel should _link to multimedia:libs/ladspa
superseded by 210502