Overview
Request History
anubisg1 created request
Fixed License tag as requested
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto added factory-repo-checker as a reviewer
Please review build success
factory-auto accepted review
Check script succeeded
licensedigger added legal-team as a reviewer
{"delegate": "new package ldb.risk is None"}
licensedigger accepted review
{"delegate": "new package ldb.risk is None"}
mlin7442 accepted review
No need for staging, not in tested ring projects.
babelworx accepted review
factory-repo-checker accepted review
Builds for repo X11:lxde/openSUSE_Factory
dimstar declined review
+%files -n libQt5Xdg1
+%defattr(-,root,root)
+%doc AUTHORS COPYING
+%{_libdir}/libQt5Xdg.so.1
+%{_libdir}/libQt5Xdg.so.1.0.0
+%{_datadir}/%{name}
=> the package does not comply to the SLPP: in essence it is impossible to have an ABI bump (think. libQt5Xdg.so.2) which will not conflict with the existin files from this package, thus entirely underminding the shared library packaging policy.
this is also represented in the rpmlint warning: libQt5Xdg1.i586: W: shlib-policy-nonversioned-dir /usr/share/libqt5xdg
dimstar declined request
+%files -n libQt5Xdg1
+%defattr(-,root,root)
+%doc AUTHORS COPYING
+%{_libdir}/libQt5Xdg.so.1
+%{_libdir}/libQt5Xdg.so.1.0.0
+%{_datadir}/%{name}
=> the package does not comply to the SLPP: in essence it is impossible to have an ABI bump (think. libQt5Xdg.so.2) which will not conflict with the existin files from this package, thus entirely underminding the shared library packaging policy.
this is also represented in the rpmlint warning: libQt5Xdg1.i586: W: shlib-policy-nonversioned-dir /usr/share/libqt5xdg
anubisg1 reopened request
that folder includes only translations which are specific for that library. this is a path used upstream and doesn't make any sense to split a -lang package for the library i think.
dimstar accepted review
Same mess as with Qt4 libs; they don't do ABI bumps anyway (SLPP makes only half-baked sense here)
dimstar approved review
Same mess as with Qt4 libs; they don't do ABI bumps anyway (SLPP makes only half-baked sense here)
coolo accepted request
Accept to Factory
