Overview
Request 264077 superseded
This new package is needed to add iSNS support
to the targetcli iSCSI target package. I have
tested it with targetcli and open-isns on
Factory and 13.2.
Changes since last (declined) submission:
- Removed README.me from top-level directory
and spec file, since already in tarball
- Cleaned up the spec file
- Added %doc for 3 top-level doc files to spec
- Created by lee_duncan
- In state superseded
- Supersedes 263902
- Superseded by 264204
-
Open review for
legal-team
Request History
lee_duncan created request
This new package is needed to add iSNS support
to the targetcli iSCSI target package. I have
tested it with targetcli and open-isns on
Factory and 13.2.
Changes since last (declined) submission:
- Removed README.me from top-level directory
and spec file, since already in tarball
- Cleaned up the spec file
- Added %doc for 3 top-level doc files to spec
licensedigger added legal-team as a reviewer
{"delegate": "new package ldb.risk is None"}
licensedigger accepted review
{"delegate": "new package ldb.risk is None"}
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto added factory-repo-checker as a reviewer
Please review build success
factory-auto accepted review
Check script succeeded
factory-repo-checker accepted review
Builds for repo Base:System/openSUSE_Factory
mlin7442 accepted review
No need for staging, not in tested ring projects.
dimstar declined review
target-isns.i586: W: suse-missing-rclink target-isns
The package contains an init script or systemd service file but lacks the
symlink /usr/sbin/rcFOO -> /usr/sbin/service
And please also don't own /etc and /usr/bin -> those belong to filesystem
Additionally:
/usr/bin is to be written as %{_bindir} and /etc as %{_sysconfdir}
For the man page, I stronnlgy recommend to change .gz into %{?ext_man}; if we ever change the compression of man pages, this will just work
dimstar declined request
target-isns.i586: W: suse-missing-rclink target-isns
The package contains an init script or systemd service file but lacks the
symlink /usr/sbin/rcFOO -> /usr/sbin/service
And please also don't own /etc and /usr/bin -> those belong to filesystem
Additionally:
/usr/bin is to be written as %{_bindir} and /etc as %{_sysconfdir}
For the man page, I stronnlgy recommend to change .gz into %{?ext_man}; if we ever change the compression of man pages, this will just work
superseded by 264204
