Overview

Request 298616 superseded

Popular media player

Loading...
Request History
Martin Pluskal's avatar

pluskalm created request

Popular media player


Factory Auto's avatar

factory-auto added opensuse-review-team as a reviewer

Please review sources


Factory Auto's avatar

factory-auto added factory-repo-checker as a reviewer

Please review build success


Factory Auto's avatar

factory-auto accepted review

Check script succeeded


Saul Goodman's avatar

licensedigger added legal-team as a reviewer

new_package: 0.8.3


Saul Goodman's avatar

licensedigger accepted review


Factory Repo Checker's avatar

factory-repo-checker accepted review

Builds for repo multimedia:apps/openSUSE_Factory


Max Lin's avatar

mlin7442 accepted review

No need for staging, not in tested ring projects.


Dominique Leuenberger's avatar

dimstar declined review

+%package -n %{libname}
+Summary: A library to link together with mpv player
+Group: Development/Libraries/C and C++

Libraries belong per definition to the Group "System/Libraries"

And, as you're installing icons into the themed directory (/usr/share/icons/hicolor) you should also use the corresponding macros in post:
%icon_theme_cache_post and %icon_theme_cache_postun (no parameter needed for hicolor theme)


Dominique Leuenberger's avatar

dimstar declined request

+%package -n %{libname}
+Summary: A library to link together with mpv player
+Group: Development/Libraries/C and C++

Libraries belong per definition to the Group "System/Libraries"

And, as you're installing icons into the themed directory (/usr/share/icons/hicolor) you should also use the corresponding macros in post:
%icon_theme_cache_post and %icon_theme_cache_postun (no parameter needed for hicolor theme)


Martin Pluskal's avatar

pluskalm superseded request

superseded by 298786

openSUSE Build Service is sponsored by