Overview
Request 445416 superseded
- Import preset macros from systemd-rpm-macro and convert them into
scripts.
Presets are not supposed to be shipped by other packages as the
default policy needs to be reviewed by the secteam. Therefore don't
encourage packagers to do that and make those macros private to this
package.
Also convert them into real scripts so they're much easier to
maintain and debug. Also working in %posttrans is unneeded as this
package is assumed to be the only one to update the preset.
- There's no need to reload the daemon configuration as presets are
not part of the dameon config. (forwarded request 445123 from fbui)
- Created by msmeissn
- In state superseded
- Superseded by 446738
-
Open review for
factory-staging
Request History
msmeissn created request
- Import preset macros from systemd-rpm-macro and convert them into
scripts.
Presets are not supposed to be shipped by other packages as the
default policy needs to be reviewed by the secteam. Therefore don't
encourage packagers to do that and make those macros private to this
package.
Also convert them into real scripts so they're much easier to
maintain and debug. Also working in %posttrans is unneeded as this
package is assumed to be the only one to update the preset.
- There's no need to reload the daemon configuration as presets are
not part of the dameon config. (forwarded request 445123 from fbui)
licensedigger accepted review
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto added factory-repo-checker as a reviewer
Please review build success
factory-auto accepted review
Check script succeeded
dimstar_suse set openSUSE:Factory:Staging:B as a staging project
Being evaluated by staging project "openSUSE:Factory:Staging:B"
dimstar_suse accepted review
Picked openSUSE:Factory:Staging:B
factory-repo-checker reopened review
systemd-presets-branding-openSUSE is still building for repository openSUSE_Factory
jengelh accepted review
maxlin_factory added openSUSE:Factory:Staging:D as a reviewer
Being evaluated by staging project "openSUSE:Factory:Staging:D"
maxlin_factory accepted review
Moved to openSUSE:Factory:Staging:D
factory-repo-checker reopened review
factory-repo-checker accepted review
Builds for repo openSUSE:Factory:Staging:D/standard
dimstar_suse accepted review
Removing from openSUSE:Factory:Staging:D, re-evaluation needed
dimstar_suse approved review
Removing from openSUSE:Factory:Staging:D, re-evaluation needed
dimstar_suse added factory-staging as a reviewer
Requesting new staging review
superseded by 446738
+if [ $1 -gt 1 ] ; then + # + # Save the old state so we can detect which package have its + # default changed later. + # + # Note: the old version of the script is used here. + # + %{_prefix}/lib/%{generic_name}/branding-preset-states save +fiNote: old package version does potentially not have the script at all - so it can't be found