Overview

Request 461788 superseded

No description set
Loading...

Dominique Leuenberger's avatar

+AutoReq: no

Is this code REALLY that bad?


Josef Möllers's avatar

I kept the original spec file from the previous version and just modified those parts that have changed due to the update to the new version, so whatever is bad must have been bad before. Having said that ... I will fix the things Jan complained about, if it makes the product better.


Jan Engelhardt's avatar

All packages new to Factory get the same treatment irrespective of history at another place.

Request History
Josef Möllers's avatar

jmoellers created request


Saul Goodman's avatar

licensedigger accepted review

ok


Reinhard Max's avatar

rmax accepted review

ok


Factory Auto's avatar

factory-auto added opensuse-review-team as a reviewer

Please review sources


Factory Auto's avatar

factory-auto added factory-repo-checker as a reviewer

Please review build success


Factory Auto's avatar

factory-auto accepted review

Check script succeeded


Yuchen Lin's avatar

maxlin_factory added as a reviewer

Being evaluated by staging project "openSUSE:Factory:Staging:adi:291"


Yuchen Lin's avatar

maxlin_factory accepted review

Picked openSUSE:Factory:Staging:adi:291


Factory Repo Checker's avatar

factory-repo-checker accepted review

Builds for repo science:HPC/openSUSE_Tumbleweed


Dominique Leuenberger's avatar

dimstar accepted review


Jan Engelhardt's avatar

jengelh declined review

Why is this explicitly requiring libexpat1, libibumad5, libibverbs1? That's autodetected.

The main subpackage group should also not be System/Libraries; use Development/Libraries/C and C++.

ldconfig on the devel package? That smells like you need to implement the shlib guideline
and split out libopasadb1.


Jan Engelhardt's avatar

jengelh declined request

Why is this explicitly requiring libexpat1, libibumad5, libibverbs1? That's autodetected.

The main subpackage group should also not be System/Libraries; use Development/Libraries/C and C++.

ldconfig on the devel package? That smells like you need to implement the shlib guideline
and split out libopasadb1.


Nicolas Morey-Chaisemartin's avatar

NMoreyChaisemartin superseded request

superseded by 508558

openSUSE Build Service is sponsored by