Overview
Finally I had some time to think about this...
I assume the idea here is to list all packages that implement the org.freedesktop.Notifications dbus interface? Maybe the provides could name this more explicit?
We have for example already provides in the form dbus(org.freedesktop.GeoClue2) = which makes it very obvious what we expect to find there, namely the dbus interface with the respective name.
If we go this way, I agree, this could be a nice addition (for the record: gnome-shell itself implements this interface too)
Yeah, that's the idea.
dbus(org.freedesktop.Notifications)
Well, this does look better, although it creates an impression this provides was auto-generated.
a) I don't see why using this form would imply it to be autogenerated
b) there is no reason not to implement auto-generation at one point (even though it won't be possible in all cases, except if there is really a dbus service file installed.. which is not mandatory at all in order to provide a dbus service)
c) this format already exists in the distro:
rpm -q --provides geoclue2 dleyna-server dleyna-renderer gnome-keyring gnome-online-miners | grep "dbus" dbus(org.freedesktop.GeoClue2) = 2.4.5 dbus(com.intel.dleyna-server) = 0.5.0 dbus(dleyna-renderer-service) = 0.5.0 dbus(org.freedesktop.secrets) dbus(org.gnome.keyring) dbus(org.gnome.OnlineMiners.Flickr) dbus(org.gnome.OnlineMiners.GData) dbus(org.gnome.OnlineMiners.Owncloud) dbus(org.gnome.OnlineMiners.Zpj)
Request History
XRevan86 created request
gnome-review-bot accepted review
Check script succeeded
dimstar accepted review
dimstar approved review
dimstar accepted request