Request 485062 (superseded)

This request is superseded by request 494524 (Show diff)

Overview

Request 485062 superseded

No description set

Created by scarabeus_iv over 7 years ago
In state superseded
Supersedes 450486
Superseded by 494524
Open review for factory-staging

Submit zlib

Comments for request 485062 4
Comments for request 450486 7

Staging Bot (staging-bot) - about 7 years ago

reviewer

@dimstar_suse, @factory-repo-checker: review reminder

Yuchen Lin (maxlin_factory) - about 7 years ago

reviewer

our perl still unhappy with it in testsuite

Max Lin (mlin7442) - about 7 years ago

[  857s] cpan/Compress-Raw-Zlib/t/02zlib ............................... #   Failed test at t/02zlib.t line 557.
[  857s] #          got: -5
[  857s] #     expected: 0
[  857s] #   Failed test at t/02zlib.t line 568.
[  857s] #          got: -5
[  857s] #     expected: 0
[  857s] #   Failed test at t/02zlib.t line 579.
[  857s] #          got: -5
[  857s] #     expected: 0
[  857s] #   Failed test at t/02zlib.t line 598.
[  857s] #          got: -3
[  857s] #     expected: 1

Martin Pluskal (pluskalm) - about 7 years ago

Hopefully sr#494285 will fix this failures

Max Lin (mlin7442) - over 7 years ago

perl's testsuite still couldn't work with update, although the failure down to 3.

https://build.opensuse.org/package/live_build_log/openSUSE:Factory:Staging:A/perl/standard/x86_64

Max Lin (mlin7442) - over 7 years ago

CC @scarabeus_iv @kraih @pluskalm

Sebastian Riedel (kraih) - over 7 years ago

The first breaking test looks very similar to the bug from last time. There's deflateParams calls returning Z_BUF_ERROR instead of Z_OK, followed by deflate calls that succeed with Z_OK, followed by an inflate on the previously compressed data that fails with Z_DATA_ERROR instead of returning Z_OK. The deflateParams return value comes straight from zlib, so i think the probability of another zlib bug is very high.

Sebastian Riedel (kraih) - over 7 years ago

The second breaking test appears to be the exact same scenario on a slightly higher abstraction level. IO::Compress is built around Compress::Raw::Zlib.

Sebastian Riedel (kraih) - over 7 years ago

Some more context, there's an open ticket for Compress::Raw::Zlib. Looks like it's still unclear how much of the zlib API changes were intentional. https://rt.cpan.org/Public/Bug/Display.html?id=119762