Overview

Request 490219 accepted

- Also split libtic into normal and wide version libticw as those
libraries are linked with libtinfo respectively libtinfow
- The tack tool does require the old _nc_read_entry()

- Add ncurses patch 20170422
+ build-fix for termcap-configuration (report by Chi-Hsuan Yen).
+ improve terminfo manual page discussion of control- and graphics-
characters.
+ remove tic warning about "^?" in string capabilities, which was
marked as an extension (cf: 20000610, 20110820); however all Unix
implementations support this and X/Open Curses does not address it.
On the other hand, termcap never did support this feature.
+ correct missing comma-separator between string capabilities in
icl6402 and m2-nam -TD
+ restore rmir/smir in ansi+idc to better match original ansiterm+idc,
add alias ansiterm (report by Robert King).
+ amend an old check for ambiguous use of "ma" in terminfo versus
a termcap use, if the capability is cancelled to treat it as number.
+ correct a case in _nc_captoinfo() which read "%%" and emitted "%".
+ modify sscanf calls in _nc_infotocap() for patterns "%{number}%+%c"
and "%'char'%+%c" to check that the final character is really 'c',
avoiding a case in icl6404 which cannot be converted to termcap.
+ in _nc_infotocap(), add a check to ensure that terminfo "^?" is not
written to termcap, because the BSDs did not implement that.
+ in _nc_tic_expand() and _nc_infotocap(), improve string-length check
when deciding whether to use "^X" or "\xxx" format for control
characters, to make the output of tic/infocmp more predictable.
+ limit termcap "%d" width to 2 digits on input, and use "%2" in
preference to "%02" on output.
+ correct terminfo/termcap conversion of "%02" and "%03" into "%2" and

Loading...

Dominique Leuenberger's avatar

libyui-ncurses buildfail is very likely a fallout from this update:

[   57s] /home/abuild/rpmbuild/BUILD/libyui-ncurses-2.48.0/src/NCTextPad.cc: In member function 'bool NCTextPad::insert(wint_t)':
[   57s] /home/abuild/rpmbuild/BUILD/libyui-ncurses-2.48.0/src/NCTextPad.cc:381:13: error: 'color' may be used uninitialized in this function [-Werror=maybe-uninitialized]
[   57s]      setcchar( &cchar, wch, attr, color, NULL );
[   57s]      ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[   57s] /home/abuild/rpmbuild/BUILD/libyui-ncurses-2.48.0/src/NCTextPad.cc:381:47: error: 'attr' may be used uninitialized in this function [-Werror=maybe-uninitialized]
[   57s]      setcchar( &cchar, wch, attr, color, NULL );
[   57s]                                                ^
[   57s] /home/abuild/rpmbuild/BUILD/libyui-ncurses-2.48.0/src/NCTextPad.cc: In member function 'void NCTextPad::setText(const NCtext&)':
[   57s] /home/abuild/rpmbuild/BUILD/libyui-ncurses-2.48.0/src/NCTextPad.cc:493:15: error: 'color' may be used uninitialized in this function [-Werror=maybe-uninitialized]
[   57s]      short int color;
[   57s]                ^~~~~
[   57s] /home/abuild/rpmbuild/BUILD/libyui-ncurses-2.48.0/src/NCTextPad.cc:520:48: error: 'attr' may be used uninitialized in this function [-Werror=maybe-uninitialized]
[   57s]       setcchar( &cchar, wch, attr, color, NULL );

https://build.opensuse.org/package/live_build_log/openSUSE:Factory:Staging:B/libyui-ncurses/standard/x86_64



Dr. Werner Fink's avatar

More than providing a patch for libyui-ncurses https://bugzilla.suse.com/attachment.cgi?id=722325 I can not do :(


Dominique Leuenberger's avatar

Backlog, waiting for libyui-ncurses fix (upcoming sprint)


Dr. Werner Fink's avatar

What is the status now? The new changes in local ncurses do accumulate here



Request History
Dr. Werner Fink's avatar

WernerFink created request

- Also split libtic into normal and wide version libticw as those
libraries are linked with libtinfo respectively libtinfow
- The tack tool does require the old _nc_read_entry()

- Add ncurses patch 20170422
+ build-fix for termcap-configuration (report by Chi-Hsuan Yen).
+ improve terminfo manual page discussion of control- and graphics-
characters.
+ remove tic warning about "^?" in string capabilities, which was
marked as an extension (cf: 20000610, 20110820); however all Unix
implementations support this and X/Open Curses does not address it.
On the other hand, termcap never did support this feature.
+ correct missing comma-separator between string capabilities in
icl6402 and m2-nam -TD
+ restore rmir/smir in ansi+idc to better match original ansiterm+idc,
add alias ansiterm (report by Robert King).
+ amend an old check for ambiguous use of "ma" in terminfo versus
a termcap use, if the capability is cancelled to treat it as number.
+ correct a case in _nc_captoinfo() which read "%%" and emitted "%".
+ modify sscanf calls in _nc_infotocap() for patterns "%{number}%+%c"
and "%'char'%+%c" to check that the final character is really 'c',
avoiding a case in icl6404 which cannot be converted to termcap.
+ in _nc_infotocap(), add a check to ensure that terminfo "^?" is not
written to termcap, because the BSDs did not implement that.
+ in _nc_tic_expand() and _nc_infotocap(), improve string-length check
when deciding whether to use "^X" or "\xxx" format for control
characters, to make the output of tic/infocmp more predictable.
+ limit termcap "%d" width to 2 digits on input, and use "%2" in
preference to "%02" on output.
+ correct terminfo/termcap conversion of "%02" and "%03" into "%2" and


Saul Goodman's avatar

licensedigger accepted review

ok


Factory Auto's avatar

factory-auto added opensuse-review-team as a reviewer

Please review sources


Factory Auto's avatar

factory-auto added factory-repo-checker as a reviewer

Please review build success


Factory Auto's avatar

factory-auto accepted review

Check script succeeded


Dominique Leuenberger's avatar

dimstar accepted review


Factory Repo Checker's avatar

factory-repo-checker accepted review

Builds for repo Base:System/openSUSE_Tumbleweed


Staging Bot's avatar

staging-bot set openSUSE:Factory:Staging:B as a staging project

Being evaluated by staging project "openSUSE:Factory:Staging:B"


Staging Bot's avatar

staging-bot accepted review

Picked openSUSE:Factory:Staging:B


Dominique Leuenberger's avatar

dimstar_suse accepted review

Removing from openSUSE:Factory:Staging:B, re-evaluation needed


Dominique Leuenberger's avatar

dimstar_suse approved review

Removing from openSUSE:Factory:Staging:B, re-evaluation needed


Dominique Leuenberger's avatar

dimstar_suse added factory-staging as a reviewer

Requesting new staging review


Yuchen Lin's avatar

maxlin_factory set openSUSE:Factory:Staging:B as a staging project

Being evaluated by staging project "openSUSE:Factory:Staging:B"


Yuchen Lin's avatar

maxlin_factory accepted review

Picked openSUSE:Factory:Staging:B


Dominique Leuenberger's avatar

dimstar_suse accepted review

ready to accept


Dominique Leuenberger's avatar

dimstar_suse approved review

ready to accept


Dominique Leuenberger's avatar

dimstar_suse accepted request

Accept to openSUSE:Factory

openSUSE Build Service is sponsored by