Overview
Request 490307 superseded
singlespec changes
- Created by DocB
- In state superseded
- Superseded by 498482
- Open review for devel:languages:python / python-bcrypt
-
Open review for
leap-reviewers
- Open review for openSUSE:Leap:42.3:Staging:adi:25
- Open review for devel:languages:python
-
Open review for
opensuse-review-team
-
Open review for
legal-auto
Request History
DocB created request
singlespec changes
leaper added leap-reviewers as a reviewer
staging-bot added as a reviewer
Being evaluated by staging project "openSUSE:Leap:42.3:Staging:adi:25"
staging-bot accepted review
Picked openSUSE:Leap:42.3:Staging:adi:25
TheBlackCat declined review
Please fix the source url (should be "files.pythonhosted.org"). This will cause the package to be rejected by automatic Factory checks since the URL you are using right now doesn't work.
Other, smaller fixes while you are at it:
1. The indentation of the BuildRequires is mixed up
2. Please remove the commented-out "#python setup.py ..." lines
3. The %check can just be "%python_exec setup.py test".
4. Please change the "-py%{py_ver}.egg-info" to just "-py*.egg-info", not all distros put a version number there so this is more portable.
5. The %fdupes should be "%python_expand %fdupes %{buildroot}/%{$python_sitearch}" to catch all python versions while still keeping them isolated.
7. It is not longer 2016.
Not a big deal, but while you are at it please also fix the indendation
And you can delete the commented-out
TheBlackCat declined request
Please fix the source url (should be "files.pythonhosted.org"). This will cause the package to be rejected by automatic Factory checks since the URL you are using right now doesn't work.
Other, smaller fixes while you are at it:
1. The indentation of the BuildRequires is mixed up
2. Please remove the commented-out "#python setup.py ..." lines
3. The %check can just be "%python_exec setup.py test".
4. Please change the "-py%{py_ver}.egg-info" to just "-py*.egg-info", not all distros put a version number there so this is more portable.
5. The %fdupes should be "%python_expand %fdupes %{buildroot}/%{$python_sitearch}" to catch all python versions while still keeping them isolated.
7. It is not longer 2016.
Not a big deal, but while you are at it please also fix the indendation
And you can delete the commented-out
DocB reopened request
resubmit - Singlespec should be in 42.3 now
leaper added devel:languages:python as a reviewer
Submission for None by someone who is not maintainer in the devel project (devel:languages:python). Please review
leaper added opensuse-review-team as a reviewer
leaper added legal-auto as a reviewer
leaper declined review
review failed
leaper declined request
review failed
devel:languages:python/python-bcrypt@3 -> openSUSE:Leap:42.3/python-bcrypt
the submitted sources are NOT in Factory
NOTE: if you think the automated review was wrong here, please talk to the release team before reopening the request