Overview

Request 501683 accepted

- BuildIgnore group(trusted): we don't really care for this group
in the buildroot and do not want to get system-users into the
bootstrap cycle as we can avoid it. (forwarded request 501680 from dimstar)

Loading...

Dominique Leuenberger's avatar

Duplicating the not-yet addressed comments from the previous submission (CC @namtrac)

as a summary: due to this change, we now pull in systemd-mini into the buldroot (system-group-trusted:systemd); this then triggers via tmpfiles.d to createa link in /etc/os-release -> ../usr/lib/os-release which in turn makes llvm stumble over an os-release that 'exists' but can't be opened; is is happy to ignore it's absence, but is not happy when it's there but can't be read
I think the correct thing would be for llvm to handle the case of /etc/os-release being a dangling link the same way as /etc/os-release being absent completely (it does not mind the file being missing, but minds it being a dangling symlink at the moment)
n easy way out would be: BuildRequires: distribution-release (will bring you dummy-release) and thus a real /etc/os-release file to inspect

Dominique Leuenberger's avatar

I submitted fixes for the two remaining fallouts:

sr 502393  State:new        By:dimstar      When:2017-06-08T16:25:17
           submit:          home:dimstar:Factory/sysconfig@2 ->                Base:System
           Descr: Goes together with the latest permission changes, which also sets
                  root:root for /etc/ppp


sr 502394  State:new        By:dimstar      When:2017-06-08T16:25:26
           submit:          home:dimstar:Factory/filesystem@2 ->               Base:System
           Descr: Goes together with the latest permission changes, which also sets
                  root:root for /etc/ppp

Dominique Leuenberger's avatar

impossible to believe, but I tracked this change down to be responible for the llvm3_8 build failure; go figure.

as a summary: due to this change, we now pull in systemd-mini into the buldroot (system-group-trusted:systemd); this then triggers via tmpfiles.d to createa link in /etc/os-release -> ../usr/lib/os-release which in turn makes llvm stumble over an os-release that 'exists' but can't be opened; is is happy to ignore it's absence, but is not happy when it's there but can't be read


Dominique Leuenberger's avatar

@namtrac Can you please see the rest of the comments on this submission? I think the correct thing would be for llvm to handle the case of /etc/os-release being a dangling link the same way as /etc/os-release being absent completely (it does not mind the file being missing, but minds it being a dangling symlink at the moment)


Dominique Leuenberger's avatar

An easy way out would be: BuildRequires: distribution-release (will bring you dummy-release) and thus a real /etc/os-release file to inspect


Marcus Meissner's avatar

so i can keep it as-is in permissions? ;)


Dominique Leuenberger's avatar

zes, I don't think a change in permissions makes any sense - llvm3_8 would be falling flat on the nose for whatever change that happens to pull in systemd into it's build root at any moment when there is no /etc/os-release (come to think: that should break on SLE all the time, as there systemd is in every buildroot - but likely also a package adding a /etc/os-release then)


Ludwig Nussel's avatar

we need BuildIgnore here. permissions is in ring0 but system-users are not



Request History
Marcus Meissner's avatar

msmeissn created request

- BuildIgnore group(trusted): we don't really care for this group
in the buildroot and do not want to get system-users into the
bootstrap cycle as we can avoid it. (forwarded request 501680 from dimstar)


Factory Auto's avatar

factory-auto added opensuse-review-team as a reviewer

Please review sources


Factory Auto's avatar

factory-auto added factory-repo-checker as a reviewer

Please review build success


Factory Auto's avatar

factory-auto accepted review

Check script succeeded


Dominique Leuenberger's avatar

dimstar_suse set openSUSE:Factory:Staging:A as a staging project

Being evaluated by staging project "openSUSE:Factory:Staging:A"


Dominique Leuenberger's avatar

dimstar_suse accepted review

Picked openSUSE:Factory:Staging:A


Saul Goodman's avatar

licensedigger accepted review

ok


Factory Repo Checker's avatar

factory-repo-checker reopened review

can't install bzrtp-devel-1.0.5-14.1.x86_64:
package bzrtp-devel-1.0.5-14.1.x86_64 requires libbzrtp0 = 1.0.5, but none of the providers can be installed
nothing provides libbctoolbox.so.1()(64bit) needed by libbzrtp0-1.0.5-14.1.x86_64


Dominique Leuenberger's avatar

dimstar_suse changed priority to moderate => important

raising priority for openSUSE:Factory:Staging:A


Factory Repo Checker's avatar

factory-repo-checker accepted review

Builds for repo Base:System/openSUSE_Factory


Dominique Leuenberger's avatar

dimstar accepted review


Dominique Leuenberger's avatar

dimstar_suse accepted review

ready to accept


Dominique Leuenberger's avatar

dimstar_suse approved review

ready to accept


Dominique Leuenberger's avatar

dimstar_suse accepted request

Accept to openSUSE:Factory

openSUSE Build Service is sponsored by