Request 507762 (accepted)

This request supersedes: request 507031 (Show diff)

Overview

Request 507762 accepted

- Explicitly require m4 and library devel package
- Do not ship static library

- flex 2.6.4:
* Some minor performance enhancements
* honor user defined yy_* macros again
- includes changes from 2.6.3:
* several bug fixes resolved problems introduced in recent flex
versions regarding processing of comments, literals and various
quoting scenarios.
* fix buffer overflow through long path (bsc#1026047)
- includes changes from 2.6.2:
* a segfalt involving yyrestart(NULL) has been fixed
* flex should now handle quoting when mixed with m4 processing
correctly
* flex handles `[[' and `]]' correctly
* flex no longer generates non-ANSI code
* more compilation warnings were squashed in generated scanners
* prevented a buffer overflow that could occur when input buffers
were the exact wrong size
- drop flex-2.6.1-fPIC.patch
- build the shared library and split libfl

Created by pluskalm over 7 years ago
In state accepted
Supersedes 507031

Submit flex

Comments for request 507762 8
Comments for request 507031 3

Dominique Leuenberger (dimstar) - over 7 years ago

reviewer

Grub2's build failure feels like related to this submission:

[  108s] grub_script.yy.c: In function 'yy_fatal_error':
[  108s] grub_script.yy.c:18:22: error: statement with no effect [-Werror=unused-value]
[  108s]

Dominique Leuenberger (dimstar) - over 7 years ago

reviewer

CC @michael-chang @arvidjaar (grub2 maintainers)

This update of flex breaks grub2

Dominique Leuenberger (dimstar_suse) - over 7 years ago

reviewer target maintainer

grub2 maintainer is on FTO this week

Andrei Borzenkov (arvidjaar) - over 7 years ago

Yes, see https://github.com/westes/flex/issues/162. It should be fixed in current flex master, but did not check which commit exactly (I tested master). It is probably https://github.com/westes/flex/commit/f5d87f1a26f4a5c3402497008ae10e9a1345d327

Martin Pluskal (pluskalm) - over 7 years ago

author source maintainer

This is already part of 2.6.4

Andrei Borzenkov (arvidjaar) - over 7 years ago

Yes, sorry. It is due to https://github.com/westes/flex/commit/a58086a269d3d7367530c1a178644a8e5f1a374f and the fact that grub2 does #define fprintf(...) 0. I'll submit fix for grub2; do we need but report for this?

Andrei Borzenkov (arvidjaar) - over 7 years ago

SR#508197

Dominique Leuenberger (dimstar_suse) - over 7 years ago

reviewer target maintainer

Unignored: returned to active backlog.

Martin Pluskal (pluskalm) - over 7 years ago

author source maintainer

There is conflict with flex-old (which does not seems to be needed by anything) - see sr#507155

Dominique Leuenberger (dimstar) - over 7 years ago

reviewer

Responsible for the build fail https://build.opensuse.org/package/live_build_log/openSUSE:Factory:Staging:C/libsepol/standard/x86_64

[   31s] flex -t ../cil/src/cil_lexer.l > ../cil/src/cil_lexer.c
[   31s] flex: fatal internal error, exec of /usr/bin/m4 failed
[   31s] make[1]: *** [Makefile:57: ../cil/src/cil_lexer.c] Error 1

(specifically the removal of 'Requires: m4'

Dominique Leuenberger (dimstar_suse) - over 7 years ago

reviewer target maintainer

The removal of m4 dependency causes issues - needs revalidation

Request History

pluskalm created request over 7 years ago

- Explicitly require m4 and library devel package
- Do not ship static library

factory-auto added opensuse-review-team as a reviewer over 7 years ago

Please review sources

factory-auto added factory-repo-checker as a reviewer over 7 years ago

Please review build success

factory-auto accepted review over 7 years ago

Check script succeeded

staging-bot set openSUSE:Factory:Staging:C as a staging project over 7 years ago

Being evaluated by staging project "openSUSE:Factory:Staging:C"

staging-bot accepted review over 7 years ago

Picked openSUSE:Factory:Staging:C

factory-repo-checker reopened review over 7 years ago

Execution plan: devel:tools:compiler/openSUSE_Factory
found conflict of flex-old-2.5.4a-155.11.x86_64 with libfl-devel-2.6.4-142.1.x86_64:
- /usr/include/FlexLexer.h

factory-repo-checker reopened review over 7 years ago

found conflict of flex-old-2.5.4a-155.11.x86_64 with libfl-devel-2.6.4-143.1.x86_64:
- /usr/include/FlexLexer.h