Overview
Request 531688 superseded
- Created by ndas
- In state superseded
- Supersedes 530406
- Superseded by 532746
-
Open review for
repo-checker
- Open review for openSUSE:Factory:Staging:adi:50
seems ok now - let's see what the bot will find in the end
as for the patch, the default should probably be auto-detected instead of hardcoded, which would make the patch upstreamable:
UDEV_RULES_DIR equals to pkg-config --variable udevrulesdir udev UDEV_BIN_DIR equals to (pkg-config --variable udevdir udev)/rules.d
Request History
ndas created request
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto added repo-checker as a reviewer
Please review build success
factory-auto accepted review
Check script succeeded
licensedigger accepted review
ok
dimstar_suse added as a reviewer
Being evaluated by staging project "openSUSE:Factory:Staging:adi:50"
dimstar_suse accepted review
Picked openSUSE:Factory:Staging:adi:50
dimstar accepted review
superseded by 532746
+cd build +%make_install
Won't decline for this (I missed it before, and it's not wrong per se): there would be %cmake_install for this case though
-_- I will fix it in next SR!