Overview
Request 532008 superseded
New package needs for full nfs/kerberos functionality
- Created by neilbrown
- In state superseded
- Supersedes 478315
- Superseded by 532715
-
Open review for
opensuse-review-team
-
Open review for
repo-checker
+BuildRequires: systemd
Do you REALLY require the full systemd? In most cases, pkgconfig(systemd) is sufficient, which allows the build system to offer a smaller set, making the build appear earlier in the build tree
Same thing for BuildRequires: krb5-devel better to use the pkgconfig() symbol
Thanks for the review! I cannot find any documentation for how to "use the pkgconfig() symbol". Could you point me at something please.
https://en.opensuse.org/openSUSE:Package_dependencies#BuildRequires - not much info there though; might need to push this up a bit
The easiest is generally to inspect configure.ac and find lines similar to (from gssapi/configure.ac:)
PKG_CHECK_MODULES([VERTO], [libverto >= 0.2.2], [have_libverto=1], [have_libverto=])
This translates 1:1 into a BuildRequires of the form:
BuildRequires: pkgconfig(libverto) >= 0.2.2
For krb5 for example, this gives us:
PKG_CHECK_MODULES([KRB5_GSSAPI], [krb5-gssapi >= 1.12.0], => BuildRequires: pkgconfig(krb5-gssapi) >= 1.12.0
The advantage being that you do not have to worry about package renames at any point in time - the pkgconfig() symbol of the devel package will just move to wherever the .pc file is (the symbol is autogenerated for provides)
And for systemd, the test can be found in external/systemd.m4 (which is included by configure.ac):
PKG_CHECK_EXISTS(systemd, => BuildRequires: pkgconfig(systemd)
Thanks for the explanation. I've adjusted the specfile accordingly, and made the other changes you suggested. I'll resubmit shortly.
+%{_libdir}/gssproxy/proxymech.la
libtool archives are not to be shipped
libverto.pc sounds like a terrible hack - is this REALLY necessary? The defined paths make no sense on i586, as there is no /usr/lib64
mainly wondering: is it still needed for SLE12SP3 / Leap 42.3? We might want to fine-tune the condition a bit
I don't understand. What do you mean by "is it still needed for ..". How might this need change? I think it is needed. I've cleaned up the two .pc files so they don't say silly things. Using them is a bit of a hack, but some sort of hack is needed. This one seemed simplest.
+%configure \ + --prefix=/usr \ + --localstatedir=/var
The configure macro already sets appropriate prefix and localstatedir - forcing those values over any macro change sounds wrong
Request History
neilbrown created request
New package needs for full nfs/kerberos functionality
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto added repo-checker as a reviewer
Please review build success
factory-auto accepted review
Check script succeeded
licensedigger accepted review
ok
staging-bot added openSUSE:Factory:Staging:adi:64 as a reviewer
Being evaluated by staging project "openSUSE:Factory:Staging:adi:64"
staging-bot accepted review
Picked openSUSE:Factory:Staging:adi:64
dimstar declined review
Fails to,build... Implicit declaraion of writev (missin header includes
dimstar declined request
Fails to,build... Implicit declaraion of writev (missin header includes
superseded by 532715
