Overview
Could you please put back this: +# If is_opensuse is not defined, then this is an older version of SLES +# or some other distribution. So, if not defined then define it as 0 +%if 0%{!?is_opensuse:%global is_opensuse 0} +%endif
So that builds on SLES12 work again?
That is not heeded - one can use 0%{?is_opensuse} and reach the same goal without weipirdly defining variables inside the spec
I thought that as well, but it's not true for SLES12. The builds will fail until you put it back.
At least they were yesterday error: /home/abuild/rpmbuild/SOURCES/chrony.spec:96: bad %if condition
build70 failed "build chrony.spec" at Thu Oct 26 11:16:38 UTC 2017.
It looks like they are working now.
that's because he forgot the ?
on 0%{?suse_version}
- and fixed it later on
Request History
pluskalm created request
- Cleanup spec file:
* Drop pre systemd support
* Run spec-cleaner
- Modified the spec file to comment out the pool statement
in chrony.conf if _not_ building for openSUSE. (bsc#1063704).
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto added repo-checker as a reviewer
Please review build success
factory-auto accepted review
Check script succeeded
staging-bot added as a reviewer
Being evaluated by staging project "openSUSE:Factory:Staging:adi:62"
staging-bot accepted review
Picked openSUSE:Factory:Staging:adi:62
repo-checker accepted review
cycle and install check passed
dimstar accepted review
licensedigger accepted review
ok
staging-bot accepted review
ready to accept
staging-bot approved review
ready to accept
dimstar_suse accepted request
Accept to openSUSE:Factory