Overview
Request 538658 superseded
- Created by scarabeus_iv
- In state superseded
- Superseded by 539245
-
Open review for
repo-checker
-
Open review for
factory-staging
Request History
scarabeus_iv created request
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto added repo-checker as a reviewer
Please review build success
factory-auto accepted review
Check script succeeded
licensedigger accepted review
ok
AndreasStieger accepted review
ok
staging-bot set openSUSE:Factory:Staging:C as a staging project
Being evaluated by staging project "openSUSE:Factory:Staging:C"
staging-bot accepted review
Picked openSUSE:Factory:Staging:C
dimstar declined review
Please - if you switch to py 3, test the code... scons is not py3 compatible
[ 40s] scons: Reading SConscript files ...
[ 40s] File "/home/abuild/rpmbuild/BUILD/serf-1.3.9/SConstruct", line 186
[ 40s]
[ 40s] print 'Warning: Used unknown variables:', ', '.join(unknown.keys())
-> print statement has invalid syntax for py3
dimstar declined request
Please - if you switch to py 3, test the code... scons is not py3 compatible
[ 40s] scons: Reading SConscript files ...
[ 40s] File "/home/abuild/rpmbuild/BUILD/serf-1.3.9/SConstruct", line 186
[ 40s]
[ 40s] print 'Warning: Used unknown variables:', ', '.join(unknown.keys())
-> print statement has invalid syntax for py3
scarabeus_iv reopened request
maxlin_factory accepted review
Re-evaluation needed
maxlin_factory added factory-staging as a reviewer
Requesting new staging review
factory-repo-checker superseded request
superseded by 539245
scons is python3 compatible - observed error comes from libserf SConstruct (I assume there will be more such cases)
And libserf issue is resolved here - https://github.com/apache/serf/commit/d4de5a672d8c03b82ba70c1b737926bcf078f761#diff-cc8093822b396591a5530a463c87d048 - will send it asap
Thanks for chasing this down - please submit the fix, then reopen this submission so we can try to restage it (and let's hope we won't see many more of those)
This problem in scons was fixed here: https://github.com/SConsProject/scons/commit/2e0de3c55f22b3eaa7767b69740b898f3d2f46bf
This was included in the scons 3.0.0 submission as scons-3.0.0-support-python-2-prints.patch, and I have previously verified that for the Python 3 case this is effective.
Not exactly - since we no longer execute scons with python 2.7
I am testing this in home:pluskalm:python3 - changes for serf and scons submitted but there is still something missing - so lets wait with submissions