Overview

Request 539625 accepted

No description set
Loading...

Dominique Leuenberger's avatar
+%if 0%{?suse_version} >= 1230
+%bcond_without systemd
+%else
+%bcond_with systemd
+%endif

It's noble to care for suse_version < 1230 (which is probably for SLE11?) - nevertheless, it fails to build for SLE11. Also, as you have non-suse targets in the devel prj: they are ALL suse_version < 1230


Dominique Leuenberger's avatar
+%pre
+%service_add_pre %{name}.service
+
+%post
+%service_add_post %{name}.service

=> these should be wrapped at least info %if %{with systemd}, matching the bcond usage; this in turn would also fix the SLE11 build fails

Request History
Lars Vogdt's avatar

lrupp created request


Factory Auto's avatar

factory-auto added opensuse-review-team as a reviewer

Please review sources


Factory Auto's avatar

factory-auto added repo-checker as a reviewer

Please review build success


Factory Auto's avatar

factory-auto accepted review

Check script succeeded


Saul Goodman's avatar

licensedigger accepted review

ok


Staging Bot's avatar

staging-bot added as a reviewer

Being evaluated by staging project "openSUSE:Factory:Staging:adi:47"


Staging Bot's avatar

staging-bot accepted review

Picked openSUSE:Factory:Staging:adi:47


Repo Checker's avatar

repo-checker accepted review

cycle and install check passed


Dominique Leuenberger's avatar

dimstar accepted review


Dominique Leuenberger's avatar

dimstar_suse accepted review

ready to accept


Dominique Leuenberger's avatar

dimstar_suse approved review

ready to accept


Dominique Leuenberger's avatar

dimstar_suse accepted request

Accept to openSUSE:Factory

openSUSE Build Service is sponsored by