-# Copyright (c) 2017 SUSE LINUX GmbH, Nuernberg, Germany. +# Copyright (c) 2016 SUSE LINUX GmbH, Nuernberg, Germany.

Why is the changelog so borked ? I have no sense of what is actually changed.

Mihai Dincă (mdinca) - about 7 years ago

source maintainer

The current Factory/salt package is the same version (2017.7.2) but it is a different package than the one maintained by the SUSE Manager Team in https://build.opensuse.org/project/show/systemsmanagement:saltstack:products and its subprojects. Because of this, I don't think we can avoid big changelog diff.

With this SR, all these packages would be synced:

• openSUSE:Factory
• https://build.opensuse.org/package/show/systemsmanagement:saltstack/salt
• https://build.opensuse.org/package/show/systemsmanagement:saltstack:products/salt (when we release it with SUSE Manager)

This package was updated to work with python3 (for SLES15).

---

Dominique Leuenberger (dimstar) - about 7 years ago

reviewer

Has this change been discussed with the SLE Release Managers? TW is upstream to SLE; so getting this diff in here means replacing the SLE15 package as well.

Why would you not rather sync YOUR package based on what SLE15 ships?

---

Dominique Leuenberger (dimstar) - about 7 years ago

reviewer

CC @sbehlert - some words from you would be appreciated here. As this would flow into SLE, you better be aligned upfront

---

Stefan Behlert (sbehlert) - about 7 years ago

I don't like some of the changes like the missing patch annotations in the specfile, but that is fine and no objection. I'm fine with the submission, and would recommend to take this under the premise that this big deviation will be avoided in the future, and that we have more timely submits to Factory going on.

---

Mihai Dincă (mdinca) - about 7 years ago

source maintainer

If I understand correctly, this is the package that will ship with SLE15, that's why I had the task to prepare this package and do this SR. @kwk @mcalmer

@dimstar - python3 is a requirement for SLE15. So it was made because of this. It was discussed in the TCM meeting.

JFYI: the changelog compared to salt in SLE12 is "clean" and just add new changes on top of the current changelog.

Discussed the case with @sbehlert - in short: a HUGE exception is granted here for you. This is a one-off exception though. Please ensure to keep the openSUSE:Factory branch up-to-date so that such 'resets' won't be necessary 'ever again'. Fixes submitted to Update branches must be ensure to also be done in openSUSE:Factory (for future product streams)

Mihai Dincă (mdinca) - about 7 years ago

source maintainer

Thanks for letting me know. I will discuss with my colleagues (SUSE Manager) and we will do our best to prevent deviations between systemsmanagement:saltstack/salt and the salt packages maintained by us for SUSE Manager.

And to add on all this: the new salt version doesn't pass openQA https://openqa.opensuse.org/tests/540493#step/salt/1

I've just tried starting a salt-master. I've changed the /etc/salt/minion to point to master: localhost like here: https://openqa.opensuse.org/tests/540493/modules/salt/steps/1/src (line 27) and I can accept the key with the command on line 30 after i start the salt-minion. test.ping also works. Could it be that the test is somehow wrong? I see that in this image no minion was found when trying to accept the key: https://openqa.opensuse.org/tests/540493#step/salt/16